WordPress.org

Make WordPress Core

Changeset 16916


Ignore:
Timestamp:
12/14/2010 04:19:08 PM (7 years ago)
Author:
ryan
Message:

Honor defaults in wp_dropdown_users(). Props duck_. fixes #15791

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/wp-includes/user.php

    r16890 r16916  
    413413        if ( in_array( $qv['orderby'], array('email', 'url', 'registered') ) ) {
    414414            $orderby = 'user_' . $qv['orderby'];
    415         } elseif ( 'name' == $qv['orderby'] ) {
     415        } elseif ( 'name' == $qv['orderby'] || 'display_name' == $qv['orderby'] ) {
    416416            $orderby = 'display_name';
    417417        } elseif ( 'post_count' == $qv['orderby'] ) {
     
    929929 * <ol>
    930930 * <li>show_option_all - Text to show all and whether HTML option exists.</li>
    931  * <li>show_option_none - Text for show none and whether HTML option exists.
    932  *     </li>
    933  * <li>orderby - SQL order by clause for what order the users appear. Default is
    934  * 'display_name'.</li>
     931 * <li>show_option_none - Text for show none and whether HTML option exists.</li>
     932 * <li>orderby - SQL order by clause for what order the users appear. Default is 'display_name'.</li>
    935933 * <li>order - Default is 'ASC'. Can also be 'DESC'.</li>
    936934 * <li>include - User IDs to include.</li>
    937935 * <li>exclude - User IDs to exclude.</li>
    938936 * <li>multi - Default is 'false'. Whether to skip the ID attribute on the 'select' element. A 'true' value is overridden when id argument is set.</li>
    939  * <li>show - Default is 'display_name'. User table column to display. If the selected item is empty then the user_login will be displayed in parentesis</li>
     937 * <li>show - Default is 'display_name'. User table column to display. If the selected item is empty then the user_login will be displayed in parentheses</li>
    940938 * <li>echo - Default is '1'. Whether to display or retrieve content.</li>
    941939 * <li>selected - Which User ID is selected.</li>
     
    968966    extract( $r, EXTR_SKIP );
    969967
    970     $users = get_users( wp_array_slice_assoc( $args, array( 'blog_id', 'include', 'exclude', 'orderby', 'order' ) ) );
     968    $users = get_users( wp_array_slice_assoc( $r, array( 'blog_id', 'include', 'exclude', 'orderby', 'order' ) ) );
    971969
    972970    $output = '';
Note: See TracChangeset for help on using the changeset viewer.