Changeset 17001 for trunk/wp-admin/includes/media.php

Timestamp:

12/16/2010 05:48:20 PM (16 years ago)

Author:

ryan

Message:

Remove some unnecessary esc_textarea() calls. Props garyc40. see #15454

File:

• trunk/wp-admin/includes/media.php (modified) (1 diff)

trunk/wp-admin/includes/media.php

@@ -1344 +1344 @@
                         $item .= $field[ $field['input'] ];
                 elseif ( $field['input'] == 'textarea' ) {
-                        $item .= "<textarea type='text' id='$name' name='$name' $aria_required>" . esc_textarea( $field['value'] ) . '</textarea>';
+                        if ( user_can_richedit() ) { // already escaped when user_can_richedit() = false
+                                $field['value'] = esc_textarea( $field['value'] );
+                        }
+                        $item .= "<textarea type='text' id='$name' name='$name' $aria_required>" . $field['value'] . '</textarea>';
                 } else {
                         $item .= "<input type='text' class='text' id='$name' name='$name' value='" . esc_attr( $field['value'] ) . "' $aria_required />";