Changeset 17129

Timestamp:

12/24/2010 02:19:41 PM (10 years ago)

Author:

nacin

Message:

Validation fixes. props ocean90, fixes #15287.

Location:

trunk/wp-admin

Files:

• edit-comments.php (modified) (1 diff)
• includes/class-wp-ms-sites-list-table.php (modified) (3 diffs)
• includes/class-wp-ms-themes-list-table.php (modified) (3 diffs)
• includes/class-wp-plugins-list-table.php (modified) (1 diff)
• includes/dashboard.php (modified) (2 diffs)
• upload.php (modified) (1 diff)

trunk/wp-admin/edit-comments.php

@@ -238 +238 @@
 
 <?php $wp_list_table->display(); ?>
+</form>
 </div>
-</form>
 
 <div id="ajax-response"></div>

trunk/wp-admin/includes/class-wp-ms-sites-list-table.php

@@ -268 +268 @@
 
                     case 'lastupdated':
-                        echo "<td valign='top'class='$column_name column-$column_name'$style>";
+                        echo "<td valign='top' class='$column_name column-$column_name'$style>";
                             if ( 'list' == $mode )
                                 $date = 'Y/m/d';
@@ -278 +278 @@
                     break;
                 case 'registered':
-                        echo "<td valign='top'class='$column_name column-$column_name'$style>";
+                        echo "<td valign='top' class='$column_name column-$column_name'$style>";
                         if ( $blog['registered'] == '0000-00-00 00:00:00' )
                             echo '&#x2014;';
@@ -288 +288 @@
                     break;
                 case 'users':
-                        echo "<td valign='top'class='$column_name column-$column_name'$style>";
+                        echo "<td valign='top' class='$column_name column-$column_name'$style>";
                             $blogusers = get_users( array( 'blog_id' => $blog['blog_id'], 'number' => 6) );
                             if ( is_array( $blogusers ) ) {

trunk/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -218 +218 @@
             if ( 'search' != $type ) {
                 $status_links[$type] = sprintf( "<a href='%s' %s>%s</a>",
-                    add_query_arg('theme_status', $type, $url),
+                    esc_url( add_query_arg('theme_status', $type, $url) ),
                     ( $type == $status ) ? ' class="current"' : '',
                     sprintf( $text, number_format_i18n( $count ) )
@@ -294 +294 @@
  
         $class = empty( $theme['enabled'] ) ? 'inactive' : 'active';
-        $checkbox_id = md5($theme['Name']) . "_checkbox";
+        $checkbox_id = "checkbox_" . md5($theme['Name']);
         $checkbox = "<input type='checkbox' name='checked[]' value='" . esc_attr( $theme_key ) . "' id='" . $checkbox_id . "' /><label class='screen-reader-text' for='" . $checkbox_id . "' >" . __('Select') . " " . $theme['Name'] . "</label>";
 
@@ -326 +326 @@
 
                     $theme_meta = array();
+
                     if ( !empty( $theme['Version'] ) )
                         $theme_meta[] = sprintf( __( 'Version %s' ), $theme['Version'] );
-                    if ( !empty( $theme['Author'] ) ) {
-                        $author = $theme['Author'];
-                        if ( !empty( $theme['Author URI'] ) )
-                            $author = '<a href="' . $theme['Author URI'] . '" title="' . esc_attr__( 'Visit author homepage' ) . '">' . $theme['Author'] . '</a>';
-                        $theme_meta[] = sprintf( __( 'By %s' ), $author );
-                    }
+
+                    if ( !empty( $theme['Author'] ) )
+                        $theme_meta[] = sprintf( __( 'By %s' ), $theme['Author'] );
+
                     if ( !empty( $theme['Theme URI'] ) )
                         $theme_meta[] = '<a href="' . $theme['Theme URI'] . '" title="' . esc_attr__( 'Visit theme homepage' ) . '">' . __( 'Visit Theme Site' ) . '</a>';

trunk/wp-admin/includes/class-wp-plugins-list-table.php

@@ -385 +385 @@
 
         $class = $is_active ? 'active' : 'inactive';
-        $checkbox_id = md5($plugin_data['Name']) . "_checkbox";
+        $checkbox_id =  "checkbox_" . md5($plugin_data['Name']);
         $checkbox = in_array( $status, array( 'mustuse', 'dropins' ) ) ? '' : "<input type='checkbox' name='checked[]' value='" . esc_attr( $plugin_file ) . "' id='" . $checkbox_id . "' /><label class='screen-reader-text' for='" . $checkbox_id . "' >" . __('Select') . " " . $plugin_data['Name'] . "</label>";
         if ( 'dropins' != $context ) {

trunk/wp-admin/includes/dashboard.php

@@ -443 +443 @@
         <p>
             <input type="text" name="s" value="" size="17" />
-            <?php submit_button( __( 'Search Users' ), 'button', 'submit', false ); ?>
+            <?php submit_button( __( 'Search Users' ), 'button', 'submit', false, array( 'id' => 'submit_users' ) ); ?>
         </p>
     </form>
@@ -450 +450 @@
         <p>
             <input type="text" name="s" value="" size="17" />
-            <?php submit_button( __( 'Search Sites' ), 'button', 'submit', false ); ?>
+            <?php submit_button( __( 'Search Sites' ), 'button', 'submit', false, array( 'id' => 'submit_sites' ) ); ?>
         </p>
     </form>

trunk/wp-admin/upload.php

@@ -214 +214 @@
 <?php find_posts_div(); ?>
 <br class="clear" />
-</div>
+
 </form>
-<br class="clear" />
-
 </div>