Changeset 17129 for trunk/wp-admin/includes/class-wp-ms-themes-list-table.php

Timestamp:

12/24/2010 02:19:41 PM (15 years ago)

Author:

nacin

Message:

Validation fixes. props ocean90, fixes #15287.

File:

• trunk/wp-admin/includes/class-wp-ms-themes-list-table.php (modified) (3 diffs)

trunk/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -218 +218 @@
             if ( 'search' != $type ) {
                 $status_links[$type] = sprintf( "<a href='%s' %s>%s</a>",
-                    add_query_arg('theme_status', $type, $url),
+                    esc_url( add_query_arg('theme_status', $type, $url) ),
                     ( $type == $status ) ? ' class="current"' : '',
                     sprintf( $text, number_format_i18n( $count ) )
@@ -294 +294 @@
  
         $class = empty( $theme['enabled'] ) ? 'inactive' : 'active';
-        $checkbox_id = md5($theme['Name']) . "_checkbox";
+        $checkbox_id = "checkbox_" . md5($theme['Name']);
         $checkbox = "<input type='checkbox' name='checked[]' value='" . esc_attr( $theme_key ) . "' id='" . $checkbox_id . "' /><label class='screen-reader-text' for='" . $checkbox_id . "' >" . __('Select') . " " . $theme['Name'] . "</label>";
 
@@ -326 +326 @@
 
                     $theme_meta = array();
+
                     if ( !empty( $theme['Version'] ) )
                         $theme_meta[] = sprintf( __( 'Version %s' ), $theme['Version'] );
-                    if ( !empty( $theme['Author'] ) ) {
-                        $author = $theme['Author'];
-                        if ( !empty( $theme['Author URI'] ) )
-                            $author = '<a href="' . $theme['Author URI'] . '" title="' . esc_attr__( 'Visit author homepage' ) . '">' . $theme['Author'] . '</a>';
-                        $theme_meta[] = sprintf( __( 'By %s' ), $author );
-                    }
+
+                    if ( !empty( $theme['Author'] ) )
+                        $theme_meta[] = sprintf( __( 'By %s' ), $theme['Author'] );
+
                     if ( !empty( $theme['Theme URI'] ) )
                         $theme_meta[] = '<a href="' . $theme['Theme URI'] . '" title="' . esc_attr__( 'Visit theme homepage' ) . '">' . __( 'Visit Theme Site' ) . '</a>';