Changeset 17234

Timestamp:

01/07/2011 04:39:18 PM (14 years ago)

Author:

nacin

Message:

Revert _admin_bar_preferences() and add a class to the table row to allow it to be hidden. Forcing the use of CSS at least attempts to ensure that the developer will recognize that the saving aspect isn't handled. Handle this in the future across all settings screens. Reverts [17161]. fixes #16004.

Location:

trunk

Files:

• wp-admin/user-edit.php (modified) (1 diff)
• wp-includes/admin-bar.php (modified) (1 diff)

trunk/wp-admin/user-edit.php

@@ -214 +214 @@
 </tr>
 <?php endif; ?>
+<tr>
+<th scope="row" class="show-admin-bar"><?php _e('Show Admin Bar')?></th>
+<td><fieldset><legend class="screen-reader-text"><span><?php _e('Show Admin Bar') ?></span></legend>
+<label for="admin_bar_front">
+<input name="admin_bar_front" type="checkbox" id="admin_bar_front" value="1" <?php checked( _get_admin_bar_pref( 'front', $profileuser->ID ) ); ?> />
+<?php /* translators: Show admin bar when viewing site */ _e( 'when viewing site' ); ?></label><br />
+<label for="admin_bar_admin">
+<input name="admin_bar_admin" type="checkbox" id="admin_bar_admin" value="1" <?php checked( _get_admin_bar_pref( 'admin', $profileuser->ID ) ); ?> />
+<?php /* translators: Show admin bar in dashboard */ _e( 'in dashboard' ); ?></label>
+</td>
+</tr>
 <?php do_action('personal_options', $profileuser); ?>
 </table>

trunk/wp-includes/admin-bar.php

@@ -361 +361 @@
 }
 
-/**
- * Add the admin bar display preferences to user profiles.
- *
- * @since 3.1.0
- * @access private
- */
-function _admin_bar_preferences( $profileuser ) {
 ?>
-<tr>
-<th scope="row"><?php _e('Show Admin Bar')?></th>
-<td><fieldset><legend class="screen-reader-text"><span><?php _e('Show Admin Bar') ?></span></legend>
-<label for="admin_bar_front">
-<input name="admin_bar_front" type="checkbox" id="admin_bar_front" value="1" <?php checked( _get_admin_bar_pref( 'front', $profileuser->ID ) ); ?> />
-<?php /* translators: Show admin bar when viewing site */ _e( 'when viewing site' ); ?></label><br />
-<label for="admin_bar_admin">
-<input name="admin_bar_admin" type="checkbox" id="admin_bar_admin" value="1" <?php checked( _get_admin_bar_pref( 'admin', $profileuser->ID ) ); ?> />
-<?php /* translators: Show admin bar in dashboard */ _e( 'in dashboard' ); ?></label>
-</td>
-</tr>
-<?php
-}
-add_action( 'personal_options', '_admin_bar_preferences' );
-
-?>