Changeset 17475 for trunk/wp-admin/includes/class-wp-list-table.php

Timestamp:

02/22/2011 04:24:20 AM (15 years ago)

Author:

nacin

Message:

Use get_comments_number() in comments_bubble() method. Removes chance of sprintf arguments error due to percent encoding in URLs and kills unnecessary translations. Escape translations into attributes. esc_url on admin_url. fixes #16611 for trunk.

File:

• trunk/wp-admin/includes/class-wp-list-table.php (modified) (1 diff)

trunk/wp-admin/includes/class-wp-list-table.php

@@ -421 +421 @@
                         echo '<strong>';
 
-                $link = "<a href='" . add_query_arg( 'p', $post_id, admin_url('edit-comments.php') ) . "' title='$pending_phrase' class='post-com-count'><span class='comment-count'>%s</span></a>";
-
-                comments_number(
-                        sprintf( $link, /* translators: comment count link */ _x( '0', 'comment count' ) ),
-                        sprintf( $link, /* translators: comment count link */ _x( '1', 'comment count' ) ),
-                        sprintf( $link, /* translators: comment count link: % will be substituted by comment count */ _x( '%', 'comment count' ) )
-                );
+                $link = "<a href='" . esc_url( add_query_arg( 'p', $post_id, admin_url( 'edit-comments.php' ) ) ) . "' title='" . esc_attr( $pending_phrase ) . "' class='post-com-count'><span class='comment-count'>%s</span></a>";
+
+                printf( $link, number_format_i18n( get_comments_number() ) );
 
                 if ( $pending_comments )