Changeset 17563 for trunk/wp-includes/class-http.php

Timestamp:

03/26/2011 03:32:05 AM (14 years ago)

Author:

dd32

Message:

Correct logic for cURL Errors, add extra sanity protection in ::processHeaders to guard against null inputs. See #16236

File:

• trunk/wp-includes/class-http.php (modified) (3 diffs)

trunk/wp-includes/class-http.php

@@ -360 +360 @@
         $cookies = array();
         $newheaders = array();
-        foreach ( $headers as $tempheader ) {
+        foreach ( (array) $headers as $tempheader ) {
             if ( empty($tempheader) )
                 continue;
@@ -1122 +1122 @@
      * @var string
      */
-    private $headers;
+    private $headers = '';
 
     /**
@@ -1260 +1260 @@
 
         // If no response, and It's not a HEAD request with valid headers returned
-        if ( empty($theResponse) && 'HEAD' != $args['method'] && ! empty($this->headers) ) {
+        if ( empty($theResponse) && ('HEAD' != $args['method'] || empty($this->headers)) ) {
             if ( $curl_error = curl_error($handle) )
                 return new WP_Error('http_request_failed', $curl_error);