Changeset 17847

Timestamp:

05/09/2011 11:15:38 PM (15 years ago)

Author:

lancewillett

Message:

Twenty Eleven: fix changes in r17846, props nacin - see #17198

• Simplify WP_Query call to pass args directly
• Don't use Yoda Conditions for <, >, <=, >= as they can be hard to read (ref: ​http://codex.wordpress.org/WordPress_Coding_Standards#Yoda_Conditions)
• Fix typo in query args

File:

• trunk/wp-content/themes/twentyeleven/showcase.php (modified) (2 diffs)

trunk/wp-content/themes/twentyeleven/showcase.php

@@ -44 +44 @@
                                         $featured_args = array(
                                                 'post__in' => $sticky,
-                                                'post_status' => 'published',
+                                                'post_status' => 'publish',
                                                 'posts_per_page' => 10,
                                         );
 
                                         // The Featured Posts query.
-                                        $featured = new WP_Query();
-                                        $featured->query( $featured_args );
+                                        $featured = new WP_Query( $featured_args );
 
                                         // Proceed only if sticky posts exist.
-                                        if ( 0 < $featured->post_count ) :
+                                        if ( $featured->have_posts() ) :
 
                                         /**
@@ -119 +118 @@
                                 <?php
                                         // Show slider only if we have more than one featured post.
-                                        if ( 1 < $featured->post_count ) :
+                                        if ( $featured->post_count > 1 ) :
                                 ?>
                                 <nav class="feature-slider">