Changeset 18932 for trunk/wp-includes/post.php

Timestamp:

10/10/2011 08:52:44 PM (15 years ago)

Author:

ryan

Message:

Count only published posts when updating term counts. Fire term count updates on transition_post_status. Props joehoyle. see #17548

File:

• trunk/wp-includes/post.php (modified) (2 diffs)

trunk/wp-includes/post.php

@@ -2732 +2732 @@
         wp_transition_post_status('publish', $old_status, $post);
 
-        // Update counts for the post's terms.
-        foreach ( (array) get_object_taxonomies('post') as $taxonomy ) {
-                $tt_ids = wp_get_object_terms($post_id, $taxonomy, array('fields' => 'tt_ids'));
-                wp_update_term_count($tt_ids, $taxonomy);
-        }
-
         do_action('edit_post', $post_id, $post);
         do_action('save_post', $post_id, $post);
@@ -5313 +5307 @@
 add_filter( 'wp_get_object_terms', '_post_format_wp_get_object_terms' );
 
+/**
+ * Update the custom taxonomies' term counts when a post's status is changed. For example, default posts term counts (for custom taxonomies) don't include private / draft posts.
+ * 
+ * @access private
+ * @param string $new_status
+ * @param string $old_status
+ * @param object $post
+ * @since 3.3.0
+ */
+function _update_term_count_on_transition_post_status( $new_status, $old_status, $post ) {
+        // Update counts for the post's terms.
+        foreach ( (array) get_object_taxonomies( $post->post_type ) as $taxonomy ) {
+                $tt_ids = wp_get_object_terms( $post->ID, $taxonomy, array( 'fields' => 'tt_ids' ) );
+                wp_update_term_count( $tt_ids, $taxonomy );
+        }
+}
 ?>