Changeset 18964

Timestamp:

10/13/2011 10:43:38 AM (15 years ago)

Author:

dd32

Message:

WP_Filesystem_*::mkdir() untrailingslash path consistently, don't waste time attempting to create an "empty" path. See #15575. Props lordandrei and SergeyBiryukov for initial patches.

Location:

trunk/wp-admin/includes

Files:

• class-wp-filesystem-direct.php (modified) (1 diff)
• class-wp-filesystem-ftpext.php (modified) (1 diff)
• class-wp-filesystem-ftpsockets.php (modified) (1 diff)
• class-wp-filesystem-ssh2.php (modified) (1 diff)

trunk/wp-admin/includes/class-wp-filesystem-direct.php

@@ -288 +288 @@
                 $path = untrailingslashit($path);
                 if ( empty($path) )
-                        $path = '/';
+                        return false;
 
                 if ( ! $chmod )

trunk/wp-admin/includes/class-wp-filesystem-ftpext.php

@@ -248 +248 @@
         }
         function mkdir($path, $chmod = false, $chown = false, $chgrp = false) {
+                $path = untrailingslashit($path);
+                if ( empty($path) )
+                        return false;
+
                 if ( !@ftp_mkdir($this->link, $path) )
                         return false;

trunk/wp-admin/includes/class-wp-filesystem-ftpsockets.php

@@ -268 +268 @@
 
         function mkdir($path, $chmod = false, $chown = false, $chgrp = false ) {
+                $path = untrailingslashit($path);
+                if ( empty($path) )
+                        return false;
+
                 if ( ! $this->ftp->mkdir($path) )
                         return false;

trunk/wp-admin/includes/class-wp-filesystem-ssh2.php

@@ -312 +312 @@
         function mkdir($path, $chmod = false, $chown = false, $chgrp = false) {
                 $path = untrailingslashit($path);
+                if ( empty($path) )
+                        return false;
+
                 if ( ! $chmod )
                         $chmod = FS_CHMOD_DIR;