Changeset 19158

Timestamp:

11/04/2011 05:41:38 PM (15 years ago)

Author:

ryan

Message:

If an empty menu ID is passed, derive it from the title and issue a _doing_it_wrong() notice. see #18197

File:

• trunk/wp-includes/class-wp-admin-bar.php (modified) (1 diff)

trunk/wp-includes/class-wp-admin-bar.php

@@ -71 +71 @@
                         $args = array_merge( array( 'parent' => func_get_arg(0) ), func_get_arg(2) );
 
-                // Ensure we have a valid ID and title.
-                if ( empty( $args['title'] ) || empty( $args['id'] ) )
+                // Ensure we have a valid title.
+                if ( empty( $args['title'] ) )
                         return false;
+
+                if ( empty( $args['id'] ) ) {
+                        _doing_it_wrong( __METHOD__, __( 'The menu ID should not be empty.' ), '3.3' );
+                        $args['id'] = esc_attr( sanitize_title( trim( $args['title'] ) ) );
+                }
 
                 $defaults = array(