Changeset 19582 for trunk/wp-content/themes/twentyeleven/image.php

Timestamp:

12/10/2011 07:18:51 PM (14 years ago)

Author:

ryan

Message:

More consistent attribute escaping. Props nacin.

File:

• trunk/wp-content/themes/twentyeleven/image.php (modified) (3 diffs)

trunk/wp-content/themes/twentyeleven/image.php

@@ -28 +28 @@
                                 <?php
                                     $metadata = wp_get_attachment_metadata();
-                                    printf( __( '<span class="meta-prep meta-prep-entry-date">Published </span> <span class="entry-date"><abbr class="published" title="%1$s">%2$s</abbr></span> at <a href="%3$s" title="Link to full-size image">%4$s &times; %5$s</a> in <a href="%6$s" title="Return to %7$s" rel="gallery">%7$s</a>', 'twentyeleven' ),
+                                    printf( __( '<span class="meta-prep meta-prep-entry-date">Published </span> <span class="entry-date"><abbr class="published" title="%1$s">%2$s</abbr></span> at <a href="%3$s" title="Link to full-size image">%4$s &times; %5$s</a> in <a href="%6$s" title="Return to %7$s" rel="gallery">%8$s</a>', 'twentyeleven' ),
                                         esc_attr( get_the_time() ),
                                         get_the_date(),
@@ -35 +35 @@
                                         $metadata['height'],
                                         esc_url( get_permalink( $post->post_parent ) ),
+                                        esc_attr( strip_tags( get_the_title( $post->post_parent ) ) ),
                                         get_the_title( $post->post_parent )
                                     );
@@ -71 +72 @@
     }
 ?>
-                                    <a href="<?php echo esc_url( $next_attachment_url ); ?>" title="<?php echo esc_attr( get_the_title() ); ?>" rel="attachment"><?php
+                                    <a href="<?php echo esc_url( $next_attachment_url ); ?>" title="<?php the_title_attribute(); ?>" rel="attachment"><?php
                                     $attachment_size = apply_filters( 'twentyeleven_attachment_size', 848 );
                                     echo wp_get_attachment_image( $post->ID, array( $attachment_size, 1024 ) ); // filterable image width with 1024px limit for image height.