Changeset 19582 for trunk/wp-content/themes/twentyten/loop-attachment.php

Timestamp:

12/10/2011 07:18:51 PM (14 years ago)

Author:

ryan

Message:

More consistent attribute escaping. Props nacin.

File:

• trunk/wp-content/themes/twentyten/loop-attachment.php (modified) (4 diffs)

trunk/wp-content/themes/twentyten/loop-attachment.php

@@ -19 +19 @@
 
                 <?php if ( ! empty( $post->post_parent ) ) : ?>
-                    <p class="page-title"><a href="<?php echo get_permalink( $post->post_parent ); ?>" title="<?php esc_attr( printf( __( 'Return to %s', 'twentyten' ), get_the_title( $post->post_parent ) ) ); ?>" rel="gallery"><?php
+                    <p class="page-title"><a href="<?php echo get_permalink( $post->post_parent ); ?>" title="<?php echo esc_attr( sprintf( __( 'Return to %s', 'twentyten' ), strip_tags( get_the_title( $post->post_parent ) ) ) ); ?>" rel="gallery"><?php
                         /* translators: %s - title of parent post */
                         printf( __( '<span class="meta-nav">&larr;</span> %s', 'twentyten' ), get_the_title( $post->post_parent ) );
@@ -34 +34 @@
                                 sprintf( '<span class="author vcard"><a class="url fn n" href="%1$s" title="%2$s" rel="author">%3$s</a></span>',
                                     get_author_posts_url( get_the_author_meta( 'ID' ) ),
-                                    sprintf( esc_attr__( 'View all posts by %s', 'twentyten' ), get_the_author() ),
+                                    esc_attr( sprintf( __( 'View all posts by %s', 'twentyten' ), get_the_author() ) ),
                                     get_the_author()
                                 )
@@ -86 +86 @@
     }
 ?>
-                        <p class="attachment"><a href="<?php echo $next_attachment_url; ?>" title="<?php echo esc_attr( get_the_title() ); ?>" rel="attachment"><?php
+                        <p class="attachment"><a href="<?php echo $next_attachment_url; ?>" title="<?php the_title_attribute(); ?>" rel="attachment"><?php
                             $attachment_width  = apply_filters( 'twentyten_attachment_size', 900 );
                             $attachment_height = apply_filters( 'twentyten_attachment_height', 900 );
@@ -97 +97 @@
                         </div><!-- #nav-below -->
 <?php else : ?>
-                        <a href="<?php echo wp_get_attachment_url(); ?>" title="<?php echo esc_attr( get_the_title() ); ?>" rel="attachment"><?php echo basename( get_permalink() ); ?></a>
+                        <a href="<?php echo wp_get_attachment_url(); ?>" title="<?php the_title_attribute(); ?>" rel="attachment"><?php echo basename( get_permalink() ); ?></a>
 <?php endif; ?>
                         </div><!-- .entry-attachment -->