Changeset 19734

Timestamp:

01/13/2012 06:37:46 PM (14 years ago)

Author:

duck_

Message:

Update hierarchy for all hierarchical post types when deleting a parent post, not just for pages. Fixes #19637.

File:

• trunk/wp-includes/post.php (modified) (3 diffs)

trunk/wp-includes/post.php

@@ -1985 +1985 @@
     $parent_where = array( 'post_parent' => $postid );
 
+    if ( is_post_type_hierarchical( $post->post_type ) ) {
+        // Point children of this page to its parent, also clean the cache of affected children
+        $children_query = $wpdb->prepare( "SELECT * FROM $wpdb->posts WHERE post_parent = %d AND post_type = %s", $postid, $post->post_type );
+        $children = $wpdb->get_results( $children_query );
+
+        $wpdb->update( $wpdb->posts, $parent_data, $parent_where + array( 'post_type' => $post->post_type ) );
+    }
+
     if ( 'page' == $post->post_type) {
         // if the page is defined in option page_on_front or post_for_posts,
@@ -1995 +2003 @@
             delete_option('page_for_posts');
         }
-
-        // Point children of this page to its parent, also clean the cache of affected children
-        $children_query = $wpdb->prepare("SELECT * FROM $wpdb->posts WHERE post_parent = %d AND post_type='page'", $postid);
-        $children = $wpdb->get_results($children_query);
-
-        $wpdb->update( $wpdb->posts, $parent_data, $parent_where + array( 'post_type' => 'page' ) );
     } else {
         unstick_post($postid);
@@ -2036 +2038 @@
     if ( 'page' == $post->post_type ) {
         clean_page_cache($postid);
-
-        foreach ( (array) $children as $child )
-            clean_page_cache($child->ID);
     } else {
         clean_post_cache($postid);
+    }
+
+    if ( is_post_type_hierarchical( $post->post_type ) ) {
+        foreach ( (array) $children as $child )
+            clean_post_cache( $child->ID );
     }