Changeset 19778

Timestamp:

01/28/2012 08:40:55 PM (15 years ago)

Author:

duck_

Message:

Redirect bare category URLs for permalink structures starting with %category%. Fixes #19876.

When using a structure like /%category%/%postname%/ it might be thought that /uncategorized/
(missing the "/category/" base) results in the category archive. Previously this worked due to
$walk_dirs = true for the post permalink structure, but canonical didn't redirect it. Now
there is no rewrite rule to match => 404. The fix is to use a canonical redirect.

File:

• trunk/wp-includes/canonical.php (modified) (2 diffs)

trunk/wp-includes/canonical.php

@@ -94 +94 @@
 
                 if ( ! $redirect_url )
-                        $redirect_url = redirect_guess_404_permalink();
+                        $redirect_url = redirect_guess_404_permalink( $requested_url );
 
         } elseif ( is_object($wp_rewrite) && $wp_rewrite->using_permalinks() ) {
@@ -418 +418 @@
 
 /**
- * Attempts to guess correct post based on query vars.
+ * Attempts to guess the correct URL from the current URL (that produced a 404) or
+ * the current query variables.
  *
  * @since 2.3.0
  * @uses $wpdb
  *
- * @return bool|string Returns False, if it can't find post, returns correct
- *              location on success.
+ * @param string $current_url Optional. The URL that has 404'd.
+ * @return bool|string The correct URL if one is found. False on failure.
  */
-function redirect_guess_404_permalink() {
-        global $wpdb;
-
-        if ( !get_query_var('name') )
-                return false;
-
-        $where = $wpdb->prepare("post_name LIKE %s", like_escape( get_query_var('name') ) . '%');
-
-        // if any of post_type, year, monthnum, or day are set, use them to refine the query
-        if ( get_query_var('post_type') )
-                $where .= $wpdb->prepare(" AND post_type = %s", get_query_var('post_type'));
-        if ( get_query_var('year') )
-                $where .= $wpdb->prepare(" AND YEAR(post_date) = %d", get_query_var('year'));
-        if ( get_query_var('monthnum') )
-                $where .= $wpdb->prepare(" AND MONTH(post_date) = %d", get_query_var('monthnum'));
-        if ( get_query_var('day') )
-                $where .= $wpdb->prepare(" AND DAYOFMONTH(post_date) = %d", get_query_var('day'));
-
-        $post_id = $wpdb->get_var("SELECT ID FROM $wpdb->posts WHERE $where AND post_status = 'publish'");
-        if ( !$post_id )
-                return false;
-        return get_permalink($post_id);
+function redirect_guess_404_permalink( $current_url = '' ) {
+        global $wpdb, $wp_rewrite;
+
+        if ( ! empty( $current_url ) )
+                $parsed_url = @parse_url( $current_url );
+
+        // Attempt to redirect bare category slugs if the permalink structure starts
+        // with the %category% tag.
+        if ( isset( $parsed_url['path'] )
+                && preg_match( '#^[^%]+%category%#', $wp_rewrite->permalink_structure )
+                && $cat = get_category_by_path( $parsed_url['path'] )
+        ) {
+                if ( ! is_wp_error( $cat ) )
+                        return get_term_link( $cat );
+        }
+
+        if ( get_query_var('name') ) {
+                $where = $wpdb->prepare("post_name LIKE %s", like_escape( get_query_var('name') ) . '%');
+
+                // if any of post_type, year, monthnum, or day are set, use them to refine the query
+                if ( get_query_var('post_type') )
+                        $where .= $wpdb->prepare(" AND post_type = %s", get_query_var('post_type'));
+                if ( get_query_var('year') )
+                        $where .= $wpdb->prepare(" AND YEAR(post_date) = %d", get_query_var('year'));
+                if ( get_query_var('monthnum') )
+                        $where .= $wpdb->prepare(" AND MONTH(post_date) = %d", get_query_var('monthnum'));
+                if ( get_query_var('day') )
+                        $where .= $wpdb->prepare(" AND DAYOFMONTH(post_date) = %d", get_query_var('day'));
+
+                $post_id = $wpdb->get_var("SELECT ID FROM $wpdb->posts WHERE $where AND post_status = 'publish'");
+                if ( ! $post_id )
+                        return false;
+                return get_permalink( $post_id );
+        }
+
+        return false;
 }