Changeset 19857

Timestamp:

02/07/2012 09:06:52 PM (13 years ago)

Author:

ryan

Message:

Change feature filter from post to get so feature selections aren't lost when paging. Props SergeyBiryukov. fixes #18094

Location:

trunk/wp-admin/includes

Files:

• class-wp-theme-install-list-table.php (modified) (1 diff)
• theme-install.php (modified) (2 diffs)

trunk/wp-admin/includes/class-wp-theme-install-list-table.php

@@ -67 +67 @@
                 }
 
-                if ( !empty( $_POST['features'] ) ) {
-                    $terms = $_POST['features'];
+                if ( !empty( $_REQUEST['features'] ) ) {
+                    $terms = $_REQUEST['features'];
                     $terms = array_map( 'trim', $terms );
                     $terms = array_map( 'sanitize_title_with_dashes', $terms );

trunk/wp-admin/includes/theme-install.php

@@ -78 +78 @@
 ?>
 <h4><?php _e('Feature Filter') ?></h4>
-<form method="post" action="<?php echo self_admin_url( 'theme-install.php?tab=search' ); ?>">
 <p class="install-help"><?php _e('Find a theme based on specific features') ?></p>
+
+<form method="get" action="">
+    <input type="hidden" name="tab" value="search" />
     <?php
     $feature_list = get_theme_feature_list( );
@@ -95 +97 @@
 
 <li>
-    <input type="checkbox" name="features[<?php echo $feature; ?>]" id="feature-id-<?php echo $feature; ?>" value="<?php echo $feature; ?>" />
+    <input type="checkbox" name="features[]" id="feature-id-<?php echo $feature; ?>" value="<?php echo $feature; ?>" />
     <label for="feature-id-<?php echo $feature; ?>"><?php echo $feature_name; ?></label>
 </li>