Changeset 19935 for trunk/wp-admin/install-helper.php

Timestamp:

02/17/2012 12:02:42 AM (13 years ago)

Author:

nacin

Message:

Deprecate ancient "debugging" tools.

• logIO() and the global $xmlrpc_logging in XML-RPC.
• log_app() and the global $app_logging in APP.
• debug_fwrite(), debug_fopen(), debug_fclose(), and $debug.

see #20051.

File:

• trunk/wp-admin/install-helper.php (modified) (6 diffs)

trunk/wp-admin/install-helper.php

@@ -10 +10 @@
  * needing to use these functions a lot, you might experience time outs. If you
  * do, then it is advised to just write the SQL code yourself.
- *
- * You can turn debugging on, by setting $debug to 1 after you include this
- * file.
  *
  * <code>
@@ -41 +38 @@
 /** Load WordPress Bootstrap */
 require_once(dirname(dirname(__FILE__)).'/wp-load.php');
-
-/**
- * Turn debugging on or off.
- * @global bool|int $debug
- * @name $debug
- * @var bool|int
- * @since 1.0.0
- */
-$debug = 0;
 
 if ( ! function_exists('maybe_create_table') ) :
@@ -91 +79 @@
  * @subpackage Plugin
  * @uses $wpdb
- * @uses $debug
  *
  * @param string $table_name Database table name
@@ -99 +86 @@
  */
 function maybe_add_column($table_name, $column_name, $create_ddl) {
-    global $wpdb, $debug;
+    global $wpdb;
     foreach ($wpdb->get_col("DESC $table_name",0) as $column ) {
-        if ($debug) echo("checking $column == $column_name<br />");
 
         if ($column == $column_name) {
@@ -180 +166 @@
  */
 function check_column($table_name, $col_name, $col_type, $is_null = null, $key = null, $default = null, $extra = null) {
-    global $wpdb, $debug;
+    global $wpdb;
     $diffs = 0;
     $results = $wpdb->get_results("DESC $table_name");
 
     foreach ($results as $row ) {
-        if ($debug > 1) print_r($row);
 
         if ($row->Field == $col_name) {
             // got our column, check the params
-            if ($debug) echo ("checking $row->Type against $col_type\n");
             if (($col_type != null) && ($row->Type != $col_type)) {
                 ++$diffs;
@@ -206 +190 @@
             }
             if ($diffs > 0) {
-                if ($debug) echo ("diffs = $diffs returning false\n");
                 return false;
             }