Changeset 20022

Timestamp:

02/28/2012 08:13:21 PM (13 years ago)

Author:

nacin

Message:

Do not save the last visited tab on the multisite Network Themes page and Site Themes tab. These are poor UX, see #18810 for plugins. Entering these screens will always default to 'all' themes view. see #20103.

Location:

trunk

Files:

• wp-admin/includes/class-wp-ms-themes-list-table.php (modified) (1 diff)
• wp-admin/includes/upgrade.php (modified) (2 diffs)
• wp-includes/version.php (modified) (1 diff)

trunk/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -16 +16 @@
         global $status, $page;
 
-        $default_status = get_user_option( 'themes_last_view' );
-        if ( empty( $default_status ) )
-            $default_status = 'all';
-        $status = isset( $_REQUEST['theme_status'] ) ? $_REQUEST['theme_status'] : $default_status;
+        $status = isset( $_REQUEST['theme_status'] ) ? $_REQUEST['theme_status'] : 'all';
         if ( !in_array( $status, array( 'all', 'enabled', 'disabled', 'upgrade', 'search' ) ) )
             $status = 'all';
-        if ( $status != $default_status && 'search' != $status )
-            update_user_meta( get_current_user_id(), 'themes_last_view', $status );
 
         $page = $this->get_pagenum();

trunk/wp-admin/includes/upgrade.php

@@ -460 +460 @@
         upgrade_330();
 
-    if ( $wp_current_db_version < 19799 )
+    if ( $wp_current_db_version < 20022 )
         upgrade_340();
 
@@ -1235 +1235 @@
         $wpdb->query("ALTER TABLE $wpdb->comments DROP INDEX comment_approved");
         $wpdb->show_errors();
+    }
+
+    if ( $wp_current_db_version < 20022 && is_main_site() && ! defined( 'DO_NOT_UPGRADE_GLOBAL_TABLES' ) ) {
+        $wpdb->query( "DELETE FROM $wpdb->usermeta WHERE meta_key = 'themes_last_view'" );
     }
 }

trunk/wp-includes/version.php

@@ -12 +12 @@
  * @global int $wp_db_version
  */
-$wp_db_version = 19863;
+$wp_db_version = 20022;
 
 /**