Changeset 20126

Timestamp:

03/06/2012 10:28:53 PM (15 years ago)

Author:

nacin

Message:

Fix variable collision in WP_Theme->get() that rears its head when the themes bucket is cached persistently. Also correct the inline doc. see #20103.

File:

• trunk/wp-includes/class-wp-theme.php (modified) (1 diff)

trunk/wp-includes/class-wp-theme.php

@@ -486 +486 @@
                         return $this->headers_sanitized[ $header ];
 
-                // If an external object cache does not consider themes to be a persistent group, sanitize everything and cache it.
+                // If themes are a persistent group, sanitize everything and cache it. One cache add is better than many cache sets.
                 if ( self::$persistently_cache ) {
-                        foreach ( array_keys( $this->headers ) as $header )
-                                $this->headers_sanitized[ $header ] = $this->sanitize_header( $header, $this->headers[ $header ] );
+                        foreach ( array_keys( $this->headers ) as $_header )
+                                $this->headers_sanitized[ $_header ] = $this->sanitize_header( $_header, $this->headers[ $_header ] );
                         $this->cache_add( 'headers', $this->headers_sanitized );
                 } else {