Changeset 20153

Timestamp:

03/08/2012 11:19:53 AM (15 years ago)

Author:

westi

Message:

XMLRPC: Intoduce a date generation helper method to improve the dates returned over XMLRPC when we have a 0 date stored for drafts.

This improves the ability of clients to work with the new wp Post APIs. See #18429 and #19733 props maxcutler.

File:

• trunk/wp-includes/class-wp-xmlrpc-server.php (modified) (4 diffs)

trunk/wp-includes/class-wp-xmlrpc-server.php

@@ -517 +517 @@
 
         /**
+         * Convert a WordPress date string to an IXR_Date object.
+         *
+         * @access protected
+         *
+         * @param $date
+         * @return IXR_Date
+         */
+        protected function _convert_date( $date ) {
+                if ( $date === '0000-00-00 00:00:00' ) {
+                        return new IXR_Date( '00000000T00:00:00Z' );
+                }
+                return new IXR_Date( mysql2date( 'Ymd\TH:i:s', $date, false ) );
+        }
+
+        /**
          * Prepares post data for return in an XML-RPC object.
          *
@@ -527 +542 @@
         protected function _prepare_post( $post, $fields ) {
                 // holds the data for this post. built up based on $fields
-                $_post = array( 'post_id' => $post['ID'] );
+                $_post = array( 'post_id' => strval( $post['ID'] ) );
 
                 // prepare common post fields
                 $post_fields = array(
                         'post_title'        => $post['post_title'],
-                        'post_date'         => new IXR_Date( mysql2date( 'Ymd\TH:i:s', $post['post_date'], false ) ),
-                        'post_date_gmt'     => new IXR_Date( mysql2date( 'Ymd\TH:i:s', $post['post_date_gmt'], false ) ),
-                        'post_modified'     => new IXR_Date( mysql2date( 'Ymd\TH:i:s', $post['post_modified'], false ) ),
-                        'post_modified_gmt' => new IXR_Date( mysql2date( 'Ymd\TH:i:s', $post['post_modified_gmt'], false ) ),
+                        'post_date'         => $this->_convert_date( $post['post_date'] ),
+                        'post_date_gmt'     => $this->_convert_date( $post['post_date_gmt'] ),
+                        'post_modified'     => $this->_convert_date( $post['post_modified'] ),
+                        'post_modified_gmt' => $this->_convert_date( $post['post_modified_gmt'] ),
                         'post_status'       => $post['post_status'],
                         'post_type'         => $post['post_type'],
@@ -930 +945 @@
 
                 // convert the date field back to IXR form
-                $post['post_date'] = new IXR_Date( mysql2date( 'Ymd\TH:i:s', $post['post_date'], false ) );
+                $post['post_date'] = $this->_convert_date( $post['post_date'] );
 
                 // ignore the existing GMT date if it is empty or a non-GMT date was supplied in $content_struct,
@@ -937 +952 @@
                         unset( $post['post_date_gmt'] );
                 else
-                        $post['post_date_gmt'] = new IXR_Date( mysql2date( 'Ymd\TH:i:s', $post['post_date_gmt'], false ) );
+                        $post['post_date_gmt'] = $this->_convert_date( $post['post_date_gmt'] );
 
                 $this->escape( $post );