Changeset 20176 for trunk/wp-includes/class-wp-theme.php

Timestamp:

03/14/2012 10:49:36 PM (13 years ago)

Author:

nacin

Message:

Hash WP_Theme cache keys to ensure long file paths don't overflow in object backends. see #20103.

File:

• trunk/wp-includes/class-wp-theme.php (modified) (5 diffs)

trunk/wp-includes/class-wp-theme.php

@@ -130 +130 @@
 
     /**
+     * Stores an md5 hash of the theme root, to function as the cache key.
+     *
+     * @access private
+     * @var string
+     */
+    private $cache_hash;
+
+    /**
      * Flag for whether the themes cache bucket should be persistently cached.
      *
@@ -172 +180 @@
         $this->theme_root = $theme_root;
         $this->stylesheet = $theme_dir;
+        $this->cache_hash = md5( $this->theme_root . '/' . $this->stylesheet );
         $theme_file = $this->stylesheet . '/style.css';
 
@@ -441 +450 @@
      */
     private function cache_add( $key, $data ) {
-        return wp_cache_add( $key . '-' . $this->theme_root . '/' . $this->stylesheet, $data, 'themes', self::$cache_expiration );
+        return wp_cache_add( $key . '-' . $this->cache_hash, $data, 'themes', self::$cache_expiration );
     }
 
@@ -456 +465 @@
      */
     private function cache_get( $key ) {
-        return wp_cache_get( $key . '-' . $this->theme_root . '/' . $this->stylesheet, 'themes' );
+        return wp_cache_get( $key . '-' . $this->cache_hash, 'themes' );
     }
 
@@ -467 +476 @@
     public function cache_delete() {
         foreach ( array( 'theme', 'screenshot', 'screenshot_count', 'files', 'headers' ) as $key )
-            wp_cache_delete( $key . '-' . $this->theme_root . '/' . $this->stylesheet, 'themes' );
+            wp_cache_delete( $key . '-' . $this->cache_hash, 'themes' );
     }