Changeset 20299

Timestamp:

03/28/2012 09:10:29 AM (8 years ago)

Author:

koopersmith

Message:

Theme Customizer: Sanitize selectors by transforming square brackets into dashes. see #19910.

This both better conforms to the CSS spec and prevents bugs from occurring in JavaScript selector engines.

Location:

trunk/wp-includes

Files:

• class-wp-customize-control.php (modified) (1 diff)
• js/customize-controls.dev.js (modified) (1 diff)

trunk/wp-includes/class-wp-customize-control.php

@@ -146 +146 @@
      */
     protected function render() {
-        $id    = 'customize-control-' . $this->id;
+        $id    = 'customize-control-' . str_replace( '[', '-', str_replace( ']', '', $this->id ) );
         $class = 'customize-control customize-control-' . $this->type;
 

trunk/wp-includes/js/customize-controls.dev.js

@@ -49 +49 @@
 
             this.id = id;
-            this.container = $( '#customize-control-' + id );
+            this.selector = '#customize-control-' + id.replace( ']', '' ).replace( '[', '-' );
+            this.container = $( this.selector );
 
             settings = $.map( this.params.settings, function( value ) {