Changeset 20322

Timestamp:

03/29/2012 11:59:51 AM (13 years ago)

Author:

westi

Message:

XMLRPC: Fix bugs in mw_editPost hilighted by tests in ​[UT593]

• Feature image code did not actually set the feature image - See #18429
• This api call could trash post data - Fixes #20321.

File:

• trunk/wp-includes/class-wp-xmlrpc-server.php (modified) (3 diffs)

trunk/wp-includes/class-wp-xmlrpc-server.php

@@ -3976 +3976 @@
         }
 
-        $post_title = isset( $content_struct['title'] ) ? $content_struct['title'] : null;
-        $post_content = isset( $content_struct['description'] ) ? $content_struct['description'] : null;
+        if ( isset( $content_struct['title'] ) )
+            $post_title =  $content_struct['title'];
+
+        if ( isset( $content_struct['description'] ) )
+            $post_content = $content_struct['description'];
 
         $post_category = array();
@@ -3989 +3992 @@
         }
 
-        $post_excerpt = isset( $content_struct['mt_excerpt'] ) ? $content_struct['mt_excerpt'] : null;
-        $post_more = isset( $content_struct['mt_text_more'] ) ? $content_struct['mt_text_more'] : null;
+        if ( isset( $content_struct['mt_excerpt'] ) )
+            $post_excerpt =  $content_struct['mt_excerpt'];
+
+        if ( isset( $content_struct['mt_text_more'] ) )
+            $post_more =  $content_struct['mt_text_more'];
 
         $post_status = $publish ? 'publish' : 'draft';
@@ -4061 +4067 @@
             $this->set_custom_fields($post_ID, $content_struct['custom_fields']);
 
-        if ( isset ( $post_data['wp_featured_image'] ) ) {
+        if ( isset ( $content_struct['wp_featured_image'] ) ) {
             // empty value deletes, non-empty value adds/updates
-            if ( empty( $post_data['wp_featured_image'] ) ) {
+            if ( empty( $content_struct['wp_featured_image'] ) ) {
                 delete_post_thumbnail( $post_ID );
-            }
-            else {
-                if ( set_post_thumbnail( $post_ID, $post_data['wp_featured_image'] ) === false )
+            } else {
+                if ( set_post_thumbnail( $post_ID, $content_struct['wp_featured_image'] ) === false )
                     return new IXR_Error( 404, __( 'Invalid attachment ID.' ) );
             }