Changeset 20384 for trunk/wp-admin/custom-header.php

Timestamp:

04/06/2012 08:47:24 PM (15 years ago)

Author:

ryan

Message:

Make choosing a header image from the media library play nicely with file replication plugins that do not guarantee images will be retained in the local filesystem.

• When passing an attachment ID to wp_crop_image(), use load_image_to_edit() to fetch the image via a url fopen when the image does not exist in the filesystem.
• Move load_image_to_edit() to wp-admin/includes/image.php so that it is always available for admin pages loads.
• Fallback to the height and width stored in the attachment meta when the image no longer exists in the filesystem.

see #19840

File:

• trunk/wp-admin/custom-header.php (modified) (3 diffs)

trunk/wp-admin/custom-header.php

@@ -701 +701 @@
                 }
 
-                list($width, $height, $type, $attr) = getimagesize( $file );
+                if ( file_exists( $file ) ) {
+                        list( $width, $height, $type, $attr ) = getimagesize( $file );
+                } else {
+                        $data = wp_get_attachment_metadata( $id );
+                        $height = $data[ 'height' ];
+                        $width = $data[ 'width' ];
+                        unset( $data );
+                }
 
                 $max_width = 0;
@@ -717 +724 @@
                 {
                         // Add the meta-data
-                        wp_update_attachment_metadata( $id, wp_generate_attachment_metadata( $id, $file ) );
+                        if ( file_exists( $file ) )
+                                wp_update_attachment_metadata( $id, wp_generate_attachment_metadata( $id, $file ) );
                         update_post_meta( $id, '_wp_attachment_is_custom_header', get_option('stylesheet' ) );
 
@@ -725 +733 @@
                 } elseif ( $width > $max_width ) {
                         $oitar = $width / $max_width;
-                        $image = wp_crop_image($file, 0, 0, $width, $height, $max_width, $height / $oitar, false, str_replace(basename($file), 'midsize-'.basename($file), $file));
+                        $image = wp_crop_image($id, 0, 0, $width, $height, $max_width, $height / $oitar, false, str_replace(basename($file), 'midsize-'.basename($file), $file));
                         if ( is_wp_error( $image ) )
                                 wp_die( __( 'Image could not be processed. Please go back and try again.' ), __( 'Image Processing Error' ) );