Changeset 20594

Timestamp:

04/25/2012 08:24:20 PM (12 years ago)

Author:

ryan

Message:

Pass the upload iframe src url as an arg to sprintf to avoid treating octets as
format specifiers. Fixes setting the featured image on blogs containing spaces in the install path. Props rosshanney. fixes #20443

File:

• trunk/wp-admin/includes/post.php (modified) (2 diffs)

trunk/wp-admin/includes/post.php

@@ -1146 +1146 @@
         $post_id = $post_ID;
 
-    $set_thumbnail_link = '<p class="hide-if-no-js"><a title="' . esc_attr__( 'Set featured image' ) . '" href="' . esc_url( get_upload_iframe_src('image', $post_id) ) . '" id="set-post-thumbnail" class="thickbox">%s</a></p>';
-    $content = sprintf($set_thumbnail_link, esc_html__( 'Set featured image' ));
+    $upload_iframe_src = esc_url( get_upload_iframe_src('image', $post_id) );
+    $set_thumbnail_link = '<p class="hide-if-no-js"><a title="' . esc_attr__( 'Set featured image' ) . '" href="%s" id="set-post-thumbnail" class="thickbox">%s</a></p>';
+    $content = sprintf( $set_thumbnail_link, $upload_iframe_src, esc_html__( 'Set featured image' ) );
 
     if ( $thumbnail_id && get_post( $thumbnail_id ) ) {
@@ -1158 +1159 @@
         if ( !empty( $thumbnail_html ) ) {
             $ajax_nonce = wp_create_nonce( "set_post_thumbnail-$post_id" );
-            $content = sprintf($set_thumbnail_link, $thumbnail_html);
+            $content = sprintf( $set_thumbnail_link, $upload_iframe_src, $thumbnail_html );
             $content .= '<p class="hide-if-no-js"><a href="#" id="remove-post-thumbnail" onclick="WPRemoveThumbnail(\'' . $ajax_nonce . '\');return false;">' . esc_html__( 'Remove featured image' ) . '</a></p>';
         }