Changeset 20675

Timestamp:

05/01/2012 10:09:55 PM (13 years ago)

Author:

nacin

Message:

Replace commas with periods when converting ratings float values to strings, to avoid issues with localized decimal points.

In these cases, we want a period because it is going to be used by CSS.

props SergeyBiryukov.
fixes #19593.

Location:

trunk

Files:

• wp-admin/includes/class-wp-plugin-install-list-table.php (modified) (1 diff)
• wp-admin/includes/plugin-install.php (modified) (1 diff)
• wp-includes/category-template.php (modified) (1 diff)

trunk/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -218 +218 @@
             <td class="vers column-rating"<?php echo $style['rating']; ?>>
                 <div class="star-holder" title="<?php printf( _n( '(based on %s rating)', '(based on %s ratings)', $plugin['num_ratings'] ), number_format_i18n( $plugin['num_ratings'] ) ) ?>">
-                    <div class="star star-rating" style="width: <?php echo esc_attr( $plugin['rating'] ) ?>px"></div>
+                    <div class="star star-rating" style="width: <?php echo esc_attr( str_replace( ',', '.', $plugin['rating'] ) ); ?>px"></div>
                     <?php
                         $color = get_user_option('admin_color');

trunk/wp-admin/includes/plugin-install.php

@@ -343 +343 @@
         <h2><?php _e('Average Rating') ?></h2>
         <div class="star-holder" title="<?php printf(_n('(based on %s rating)', '(based on %s ratings)', $api->num_ratings), number_format_i18n($api->num_ratings)); ?>">
-            <div class="star star-rating" style="width: <?php echo esc_attr($api->rating) ?>px"></div>
+            <div class="star star-rating" style="width: <?php echo esc_attr( str_replace( ',', '.', $api->rating ) ); ?>px"></div>
             <div class="star star5"><img src="<?php echo admin_url('images/star.png?v=20110615'); ?>" alt="<?php esc_attr_e('5 stars') ?>" /></div>
             <div class="star star4"><img src="<?php echo admin_url('images/star.png?v=20110615'); ?>" alt="<?php esc_attr_e('4 stars') ?>" /></div>

trunk/wp-includes/category-template.php

@@ -673 +673 @@
         $tag_name = $tags[ $key ]->name;
         $a[] = "<a href='$tag_link' class='tag-link-$tag_id' title='" . esc_attr( call_user_func( $topic_count_text_callback, $real_count ) ) . "' style='font-size: " .
-            ( $smallest + ( ( $count - $min_count ) * $font_step ) )
+            str_replace( ',', '.', ( $smallest + ( ( $count - $min_count ) * $font_step ) ) )
             . "$unit;'>$tag_name</a>";
     }