Changeset 20675 for trunk/wp-admin/includes/class-wp-plugin-install-list-table.php

Timestamp:

05/01/2012 10:09:55 PM (14 years ago)

Author:

nacin

Message:

Replace commas with periods when converting ratings float values to strings, to avoid issues with localized decimal points.

In these cases, we want a period because it is going to be used by CSS.

props SergeyBiryukov.
fixes #19593.

File:

• trunk/wp-admin/includes/class-wp-plugin-install-list-table.php (modified) (1 diff)

trunk/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -218 +218 @@
                         <td class="vers column-rating"<?php echo $style['rating']; ?>>
                                 <div class="star-holder" title="<?php printf( _n( '(based on %s rating)', '(based on %s ratings)', $plugin['num_ratings'] ), number_format_i18n( $plugin['num_ratings'] ) ) ?>">
-                                        <div class="star star-rating" style="width: <?php echo esc_attr( $plugin['rating'] ) ?>px"></div>
+                                        <div class="star star-rating" style="width: <?php echo esc_attr( str_replace( ',', '.', $plugin['rating'] ) ); ?>px"></div>
                                         <?php
                                                 $color = get_user_option('admin_color');