Changeset 20798

Timestamp:

05/15/2012 10:14:46 PM (14 years ago)

Author:

koopersmith

Message:

Theme Customizer: Clarify wp.customize.Values API by removing Values.pass and all methods that passed through to the wp.customize.Value objects it contained. see #19910.

Location:

trunk/wp-includes/js

Files:

• customize-base.dev.js (modified) (3 diffs)
• customize-controls.dev.js (modified) (2 diffs)
• customize-preview.dev.js (modified) (1 diff)

trunk/wp-includes/js/customize-base.dev.js

@@ -292 +292 @@
         },
 
+        create: function( id ) {
+            return this.add( id, new this.defaultConstructor( api.Class.applicator, slice.call( arguments, 1 ) ) );
+        },
+
         get: function() {
             var result = {};
-
-            if ( arguments.length )
-                return this.pass( 'get', arguments );
 
             $.each( this._value, function( key, obj ) {
@@ -304 +305 @@
         },
 
-        set: function( id ) {
-            if ( this.has( id ) )
-                return this.pass( 'set', arguments );
-
-            return this.add( id, new this.defaultConstructor( api.Class.applicator, slice.call( arguments, 1 ) ) );
-        },
-
         remove: function( id ) {
             delete this._value[ id ];
             delete this._deferreds[ id ];
-        },
-
-        pass: function( fn, args ) {
-            var id, value;
-
-            args = slice.call( args );
-            id   = args.shift();
-
-            if ( ! this.has( id ) )
-                return;
-
-            value = this.value( id );
-            return value[ fn ].apply( value, args );
         },
 
@@ -375 +356 @@
     });
 
-    $.each( [ 'bind', 'unbind', 'link', 'unlink', 'sync', 'unsync', 'setter', 'resetSetter' ], function( i, method ) {
-        api.Values.prototype[ method ] = function() {
-            return this.pass( method, arguments );
-        };
-    });
-
-
     /* =====================================================================
      * An observable value that syncs with an element.

trunk/wp-includes/js/customize-controls.dev.js

@@ -436 +436 @@
 
         $.each( api.settings.settings, function( id, data ) {
-            api.set( id, id, data.value, {
+            api.create( id, id, data.value, {
                 transport: data.transport,
                 previewer: previewer
@@ -527 +527 @@
             control.element.bind( function( to ) {
                 if ( ! to )
-                    last = api.get( 'header_textcolor' );
+                    last = api( 'header_textcolor' ).get();
 
                 control.setting.set( to ? last : 'blank' );

trunk/wp-includes/js/customize-preview.dev.js

@@ -66 +66 @@
 
         $.each( api.settings.values, function( id, value ) {
-            api.set( id, value );
+            api.create( id, value );
         });
 
         preview.bind( 'setting', function( args ) {
-            api.set.apply( api, args );
+            var value = api( args.shift() );
+            if ( value )
+                value.apply( value, args );
         });