Changeset 20974

Timestamp:

06/01/2012 08:47:08 PM (12 years ago)

Author:

ryan

Message:

Don't allow unfiltered HTML comments from a frame. Props nacin. fixes #20812

Location:

trunk/wp-includes

Files:

• comment-template.php (modified) (1 diff)
• kses.php (modified) (2 diffs)

trunk/wp-includes/comment-template.php

@@ -817 +817 @@
         $post_id = $post->ID;
 
-    if ( current_user_can('unfiltered_html') )
-        wp_nonce_field('unfiltered-html-comment_' . $post_id, '_wp_unfiltered_html_comment', false);
+    if ( current_user_can( 'unfiltered_html' ) ) {
+        wp_nonce_field( 'unfiltered-html-comment_' . $post_id, '_wp_unfiltered_html_comment_disabled', false );
+        echo "<script>(function(){if(window===window.parent){document.getElementById('_wp_unfiltered_html_comment_disabled').name='_wp_unfiltered_html_comment';}})();</script>\n";
+    }
 }
 

trunk/wp-includes/kses.php

@@ -1364 +1364 @@
  */
 function kses_init_filters() {
-    // Normal filtering.
-    add_filter('pre_comment_content', 'wp_filter_kses');
+    // Normal filtering
     add_filter('title_save_pre', 'wp_filter_kses');
+
+    // Comment filtering
+    if ( current_user_can( 'unfiltered_html' ) )
+        add_filter( 'pre_comment_content', 'wp_filter_post_kses' );
+    else
+        add_filter( 'pre_comment_content', 'wp_filter_kses' );
 
     // Post filtering
@@ -1387 +1392 @@
  */
 function kses_remove_filters() {
-    // Normal filtering.
-    remove_filter('pre_comment_content', 'wp_filter_kses');
+    // Normal filtering
     remove_filter('title_save_pre', 'wp_filter_kses');
+
+    // Comment filtering
+    remove_filter( 'pre_comment_content', 'wp_filter_post_kses' );
+    remove_filter( 'pre_comment_content', 'wp_filter_kses' );
 
     // Post filtering