Changeset 20984

Timestamp:

06/04/2012 02:50:50 PM (13 years ago)

Author:

ryan

Message:

Site/user autocomplete fixes.

• Lengthen the inputs in the Right Now network dashboard widget
• Border around the whole autocomplete widget/list
• Handle long strings
• Remove some CSS color cruft from the main stylesheet and de-dupe the JS closures for open/close callbacks.

Props helenyhou
fixes #20584

Location:

trunk/wp-admin

Files:

• css/wp-admin.dev.css (modified) (3 diffs)
• includes/dashboard.php (modified) (2 diffs)
• js/site-search.dev.js (modified) (1 diff)
• js/user-search.dev.js (modified) (1 diff)

trunk/wp-admin/css/wp-admin.dev.css

@@ -890 +890 @@
     border-width: 1px;
     border-style: solid;
-    border-top: none;
-
-    background-color: #efefef;
-    border-color: #bbb;
 }
 
@@ -900 +896 @@
     white-space: nowrap;
     text-align: left;
-    color: #101010;
 }
 
@@ -907 +902 @@
     height: 100%;
     padding: 4px 10px;
-    color: #333;
 }
 
 .ui-autocomplete li a.ui-state-hover {
-    background-color: #ddd;
     cursor: pointer;
 }

trunk/wp-admin/includes/dashboard.php

@@ -445 +445 @@
     <form name="searchform" action="<?php echo network_admin_url('users.php'); ?>" method="get">
         <p>
-            <input type="search" name="s" value="" size="17" id="all-user-search-input" />
+            <input type="search" name="s" value="" size="30" id="all-user-search-input" />
             <?php submit_button( __( 'Search Users' ), 'button', 'submit', false, array( 'id' => 'submit_users' ) ); ?>
         </p>
@@ -452 +452 @@
     <form name="searchform" action="<?php echo network_admin_url('sites.php'); ?>" method="get">
         <p>
-            <input type="search" name="s" value="" size="17" id="site-search-input" />
+            <input type="search" name="s" value="" size="30" id="site-search-input" />
             <?php submit_button( __( 'Search Sites' ), 'button', 'submit', false, array( 'id' => 'submit_sites' ) ); ?>
         </p>

trunk/wp-admin/js/site-search.dev.js

@@ -1 +1 @@
 jQuery( function($) {
+    var isRTL = !! ( 'undefined' != typeof isRtl && isRtl );
     $( '#site-search-input' ).autocomplete({
-        source:   ajaxurl + '?action=autocomplete-site',
-        delay:    500,
+        source:    ajaxurl + '?action=autocomplete-site',
+        delay:     500,
         minLength: 2,
-        open: function(e, ui) { $(this).addClass('open'); },
-        close: function(e, ui) { $(this).removeClass('open'); }
+        position:  isRTL ? { my: 'right top', at: 'right bottom', offset: '0, -1' } : { offset: '0, -1' },
+        open:      function(e, ui) { $(this).addClass('open'); },
+        close:     function(e, ui) { $(this).removeClass('open'); }
     });
 });

trunk/wp-admin/js/user-search.dev.js

@@ -1 +1 @@
 jQuery( function($) {
-    var id = typeof( current_site_id ) != 'undefined' ? '&site_id=' + current_site_id : '';
+    var id = typeof( current_site_id ) != 'undefined' ? '&site_id=' + current_site_id : '',
+        isRTL = !! ( 'undefined' != typeof isRtl && isRtl ),
+        position = isRTL ? { my: 'right top', at: 'right bottom', offset: '0, -1' } : { offset: '0, -1' },
+        open = function(e, ui) {
+            $(this).addClass('open');
+        },
+        close = function(e, ui) {
+            $(this).removeClass('open');
+        };
 
     $( '#adduser-email, #newuser' ).autocomplete({
-        source:   ajaxurl + '?action=autocomplete-user&autocomplete_type=add' + id,
-        delay:    500,
+        source:    ajaxurl + '?action=autocomplete-user&autocomplete_type=add' + id,
+        delay:     500,
         minLength: 2,
-        open: function(e, ui) { $(this).addClass('open'); },
-        close: function(e, ui) { $(this).removeClass('open'); }
+        position:  position,
+        open:      open,
+        close:     close
     });
 
     $( '#user-search-input' ).autocomplete({
-        source:   ajaxurl + '?action=autocomplete-user&autocomplete_type=search' + id,
-        delay:    500,
+        source:    ajaxurl + '?action=autocomplete-user&autocomplete_type=search' + id,
+        delay:     500,
         minLength: 2,
-        open: function(e, ui) { $(this).addClass('open'); },
-        close: function(e, ui) { $(this).removeClass('open'); }
+        position:  position,
+        open:      open,
+        close:     close
     });
 
     $( '#all-user-search-input' ).autocomplete({
-        source:   ajaxurl + '?action=autocomplete-user&autocomplete_type=search-all' + id,
-        delay:    500,
+        source:    ajaxurl + '?action=autocomplete-user&autocomplete_type=search-all' + id,
+        delay:     500,
         minLength: 2,
-        open: function(e, ui) { $(this).addClass('open'); },
-        close: function(e, ui) { $(this).removeClass('open'); }
+        position:  position,
+        open:      open,
+        close:     close
     });
 });