Changeset 21003 for trunk/wp-admin/includes/dashboard.php

Timestamp:

06/05/2012 06:51:33 PM (14 years ago)

Author:

nacin

Message:

Remove user/site suggestions (autocompletion) from search inputs, as the UX isn't proper.

• Removes all instances of site-search, so away it goes. Sidesteps a number of bugs with site-search.
• Renames user-search to user-suggest, which means it better describes the current behavior (autocompletion) while allowing for future behavior (instant search).
• Ties user suggestions to a single .wp-suggest-user class.

with help from markjaquith, helenyhou, wonderboymusic.
fixes #20835.

File:

• trunk/wp-admin/includes/dashboard.php (modified) (2 diffs)

trunk/wp-admin/includes/dashboard.php

@@ -415 +415 @@
                 $actions['create-user'] = '<a href="' . network_admin_url('user-new.php') . '">' . __( 'Create a New User' ) . '</a>';
 
-        if ( ! wp_is_large_network( 'users' ) )
-                wp_enqueue_script( 'user-search' );
-
-        if ( ! wp_is_large_network( 'sites' ) )
-                wp_enqueue_script( 'site-search' );
-
         $c_users = get_user_count();
         $c_blogs = get_blog_count();
@@ -443 +437 @@
         <?php do_action( 'wpmuadminresult', '' ); ?>
 
-        <form name="searchform" action="<?php echo network_admin_url('users.php'); ?>" method="get">
+        <form action="<?php echo network_admin_url('users.php'); ?>" method="get">
                 <p>
-                        <input type="search" name="s" value="" size="30" id="all-user-search-input" />
+                        <input type="search" name="s" value="" size="30" autocomplete="off" />
                         <?php submit_button( __( 'Search Users' ), 'button', 'submit', false, array( 'id' => 'submit_users' ) ); ?>
                 </p>
         </form>
 
-        <form name="searchform" action="<?php echo network_admin_url('sites.php'); ?>" method="get">
+        <form action="<?php echo network_admin_url('sites.php'); ?>" method="get">
                 <p>
-                        <input type="search" name="s" value="" size="30" id="site-search-input" />
+                        <input type="search" name="s" value="" size="30" autocomplete="off" />
                         <?php submit_button( __( 'Search Sites' ), 'button', 'submit', false, array( 'id' => 'submit_sites' ) ); ?>
                 </p>