Changeset 21236

Timestamp:

07/09/2012 03:40:32 AM (14 years ago)

Author:

markjaquith

Message:

Do not display an error message when a plugin or theme being updated is found to already be up to date. Note the fact, and call it success. props solarissmoke. fixes #19752

File:

• trunk/wp-admin/includes/class-wp-upgrader.php (modified) (2 diffs)

trunk/wp-admin/includes/class-wp-upgrader.php

@@ -497 +497 @@
 
                         if ( !isset( $current->response[ $plugin ] ) ) {
-                                $this->skin->set_result(false);
+                                $this->skin->set_result(true);
                                 $this->skin->before();
-                                $this->skin->error('up_to_date');
+                                $this->skin->feedback('up_to_date');
                                 $this->skin->after();
-                                $results[$plugin] = false;
+                                $results[$plugin] = true;
                                 continue;
                         }
@@ -855 +855 @@
 
                         if ( !isset( $current->response[ $theme ] ) ) {
-                                $this->skin->set_result(false);
+                                $this->skin->set_result(true);
                                 $this->skin->before();
-                                $this->skin->error('up_to_date');
+                                $this->skin->feedback('up_to_date');
                                 $this->skin->after();
-                                $results[$theme] = false;
+                                $results[$theme] = true;
                                 continue;
                         }