Changeset 21623

Timestamp:

08/25/2012 05:51:21 PM (14 years ago)

Author:

lancewillett

Message:

Twenty Twelve: theme-options.php fixes from obenland, see #21685.

• Capability is already set to 'edit_theme_options' by default
• Simplify logic for form input validation

File:

• trunk/wp-content/themes/twentytwelve/inc/theme-options.php (modified) (2 diffs)

trunk/wp-content/themes/twentytwelve/inc/theme-options.php

@@ -187 +187 @@
         $output = $defaults = $this->get_default_theme_options();
 
-        // The enable fonts checkbox should boolean true or false
-        if ( ! isset( $input['enable_fonts'] ) )
-            $input['enable_fonts'] = false;
-        $output['enable_fonts'] = ( false != $input['enable_fonts'] ? true : false );
+        // The enable fonts checkbox should a boolean value, true or false.
+        $output['enable_fonts'] = ( isset( $input['enable_fonts'] ) && $input['enable_fonts'] );
 
         return apply_filters( 'twentytwelve_options_validate', $output, $input, $defaults );
@@ -221 +219 @@
             'default'    => $defaults['enable_fonts'],
             'type'       => 'option',
-            'capability' => 'edit_theme_options',
             'transport'  => 'postMessage',
         ) );