Changeset 21685

Timestamp:

08/31/2012 09:45:50 AM (12 years ago)

Author:

westi

Message:

Make sure that we always generate random numbers correctly even if the PHP build is slightly broken and truncates large integers.

Fixes #19571 props mdawaffe.

File:

• trunk/wp-includes/pluggable.php (modified) (2 diffs)

trunk/wp-includes/pluggable.php

@@ -1497 +1497 @@
 
 if ( !function_exists('wp_rand') ) :
- /**
+/**
  * Generates a random number
  *
  * @since 2.6.2
  *
- * @param int $min Lower limit for the generated number (optional, default is 0)
- * @param int $max Upper limit for the generated number (optional, default is 4294967295)
+ * @param int $min Lower limit for the generated number
+ * @param int $max Upper limit for the generated number
  * @return int A random number between min and max
  */
@@ -1532 +1532 @@
     $value = abs(hexdec($value));
 
+    // Some misconfigured 32bit environments (Entropy PHP, for example) truncate integers larger than PHP_INT_MAX to PHP_INT_MAX rather than overflowing them to floats.
+    $max_random_number = 3000000000 === 2147483647 ? (float) "4294967295" : 4294967295; // 4294967295 = 0xffffffff
+
     // Reduce the value to be within the min - max range
-    // 4294967295 = 0xffffffff = max random number
     if ( $max != 0 )
-        $value = $min + (($max - $min + 1) * ($value / (4294967295 + 1)));
+        $value = $min + ( $max - $min + 1 ) * $value / ( $max_random_number + 1 );
 
     return abs(intval($value));