Changeset 21772

Timestamp:

09/06/2012 09:50:41 AM (12 years ago)

Author:

koopersmith

Message:

Add checks for attachment metadata when formatting attachments for JS.

Prevents notices from causing malformed ajax responses.

see #21390.

File:

• trunk/wp-includes/media.php (modified) (1 diff)

trunk/wp-includes/media.php

@@ -1572 +1572 @@
     );
 
-    if ( 'image' === $type ) {
+    if ( $meta && 'image' === $type ) {
         $sizes = array();
         $base_url = str_replace( wp_basename( $attachment_url ), '', $attachment_url );
 
-        foreach ( $meta['sizes'] as $slug => $size ) {
-            $sizes[ $slug ] = array(
-                'height'      => $size['height'],
-                'width'       => $size['width'],
-                'url'         => $base_url . $size['file'],
-                'orientation' => $size['height'] > $size['width'] ? 'portrait' : 'landscape',
-            );
+        if ( isset( $meta['sizes'] ) ) {
+            foreach ( $meta['sizes'] as $slug => $size ) {
+                $sizes[ $slug ] = array(
+                    'height'      => $size['height'],
+                    'width'       => $size['width'],
+                    'url'         => $base_url . $size['file'],
+                    'orientation' => $size['height'] > $size['width'] ? 'portrait' : 'landscape',
+                );
+            }
         }