Changeset 21894

Timestamp:

09/18/2012 06:45:44 PM (14 years ago)

Author:

nacin

Message:

Replace QuickPress labels with gray prompt texts. Stylish, but also done for localization purposes (string lengths). props ocean90. fixes #21754.

Location:

trunk/wp-admin

Files:

• css/ie-rtl.css (modified) (1 diff)
• css/wp-admin-rtl.css (modified) (2 diffs)
• css/wp-admin.css (modified) (6 diffs)
• includes/dashboard.php (modified) (3 diffs)
• js/dashboard.js (modified) (1 diff)

trunk/wp-admin/css/ie-rtl.css

@@ -77 +77 @@
         padding-right: 0;
         padding-left: 1px;
-}
-
-#dashboard_quick_press h4 {
-        text-align: right;
 }
 

trunk/wp-admin/css/wp-admin-rtl.css

@@ -1851 +1851 @@
 
 /* QuickPress */
-#dashboard_quick_press h4 {
-        float: right;
-        text-align: left;
-}
-
-#dashboard_quick_press .wp-media-buttons {
-        margin: 0 5em 0.5em 0;
-}
-
-#dashboard_quick_press h4 label {
-        margin-right: 0;
-        margin-left: 10px;
-}
-
-#dashboard_quick_press .input-text-wrap,
-#dashboard_quick_press .textarea-wrap {
-        margin: 0 5em 1em 0;
-}
-
-#dashboard_quick_press #media-buttons {
-        margin: 0 5em .5em 0;
-        padding: 0;
-}
-
-#dashboard-widgets #dashboard_quick_press form p.submit {
-        margin-left: 0;
-        margin-right: 4.6em;
-}
-
 #dashboard-widgets #dashboard_quick_press form p.submit input {
         float: right;
@@ -1885 +1856 @@
 
 #dashboard-widgets #dashboard_quick_press form p.submit #save-post {
-        margin: 0 10px 0 1em;
+        margin: 0 0 0 1em;
 }
 

trunk/wp-admin/css/wp-admin.css

@@ -2811 +2811 @@
         margin-bottom: 10px;
 }
-#titlediv label { cursor: text; }
+
+#titlediv label {
+        cursor: text;
+}
 
 #titlediv div.inside {
@@ -6050 +6053 @@
 
 /* QuickPress */
-#dashboard_quick_press h4 {
-        font-family: sans-serif;
-        float: left;
-        width: 5em;
-        clear: both;
-        font-weight: normal;
-        text-align: right;
-        font-size: 12px;
-}
-
-#dashboard_quick_press h4 label {
-        margin-right: 10px;
+#dashboard_quick_press .input-text-wrap {
+        position: relative;
+}
+
+#dashboard_quick_press .prompt {
+        color: #bbb;
+        position: absolute;
+}
+
+#title-wrap label,
+#tags-input-wrap label {
+        cursor: text;
+}
+
+#title-wrap #title {
+        padding: 2px 6px;
+        font-size: 1.3em;
+        line-height: 100%;
+        outline: none;
+}
+
+#tags-input-wrap #tags-input {
+        outline: none;
+}
+
+#title-wrap #title-prompt-text {
+        font-size: 1.3em;
+        padding: 5px 8px;
+}
+
+#tags-input-wrap #tags-input-prompt-text {
+        font-size: 1em;
+        padding: 4px 8px;
 }
 
 #dashboard_quick_press .input-text-wrap,
 #dashboard_quick_press .textarea-wrap {
-        margin: 0 0 1em 5em;
+        margin: 0 0 1em 0;
 }
 
 #dashboard_quick_press .wp-media-buttons {
-        margin: 0 0 .5em 5em;
+        margin: 0 0 .2em 8px;
         padding: 0;
 }
@@ -6078 +6102 @@
 }
 
-#dashboard-widgets #dashboard_quick_press form p.submit {
-        margin-left: 4.6em;
-}
-
 #dashboard-widgets #dashboard_quick_press form p.submit input {
         float: left;
@@ -6087 +6107 @@
 
 #dashboard-widgets #dashboard_quick_press form p.submit #save-post {
-        margin: 0 0.3em 0 5px;
+        margin: 0 1em 0 0;
 }
 
@@ -8110 +8130 @@
 
 /* ru_RU: Text needs more room to breathe. */
-.locale-ru-ru #dashboard_quick_press .input-text-wrap,
-.locale-ru-ru #dashboard_quick_press .textarea-wrap,
-.locale-ru-ru #dashboard_quick_press .wp-media-buttons  {
-        margin-left: 5.7em; /* default 5em + 0.7em */
-}
-.locale-ru-ru #dashboard_quick_press h4 {
-        width: 5.7em; /* default 5.5em + 0.2em */
-}
-.locale-ru-ru #dashboard-widgets #dashboard_quick_press form p.submit {
-        margin-left: 5.3em; /* default 4.6em + 0.7em */
-}
 .locale-ru-ru .inline-edit-row fieldset label span.title {
         width: auto; /* default 5em */
@@ -8135 +8144 @@
 }
 
-/* lt_LT: QuickPress + QuickEdit */
-.locale-lt-lt #dashboard_quick_press .input-text-wrap,
-.locale-lt-lt #dashboard_quick_press .textarea-wrap,
-.locale-lt-lt #dashboard_quick_press .wp-media-buttons  {
-        margin-left: 7em;
-}
-.locale-lt-lt #dashboard_quick_press h4 {
-        width: 7em;
-}
+/* lt_LT: QuickEdit */
 .locale-lt-lt .inline-edit-row fieldset label span.title {
         width: 8em;

trunk/wp-admin/includes/dashboard.php

@@ -504 +504 @@
 
         <form name="post" action="<?php echo esc_url( admin_url( 'post.php' ) ); ?>" method="post" id="quick-press">
-                <h4 id="quick-post-title"><label for="title"><?php _e('Title') ?></label></h4>
-                <div class="input-text-wrap">
+                <div class="input-text-wrap" id="title-wrap">
+                        <label class="screen-reader-text prompt" for="title" id="title-prompt-text"><?php _e( 'Enter title here' ); ?></label>
                         <input type="text" name="post_title" id="title" autocomplete="off" value="<?php echo esc_attr( $post->post_title ); ?>" />
                 </div>
@@ -515 +515 @@
                 <?php endif; ?>
 
-                <h4 id="content-label"><label for="content"><?php _e('Content') ?></label></h4>
                 <div class="textarea-wrap">
+                        <label class="screen-reader-text" for="content"><?php _e( 'Content' ); ?></label>
                         <textarea name="content" id="content" class="mceEditor" rows="3" cols="15"><?php echo esc_textarea( $post->post_content ); ?></textarea>
                 </div>
@@ -522 +522 @@
                 <script type="text/javascript">edCanvas = document.getElementById('content');edInsertContent = null;</script>
 
-                <h4><label for="tags-input"><?php _e('Tags') ?></label></h4>
-                <div class="input-text-wrap">
+                <div class="input-text-wrap" id="tags-input-wrap">
+                        <label class="screen-reader-text prompt" for="tags-input" id="tags-input-prompt-text"><?php _e( 'Tags (separate with commas)' ); ?></label>
                         <input type="text" name="tags_input" id="tags-input" value="<?php echo get_tags_to_edit( $post->ID ); ?>" />
                 </div>

trunk/wp-admin/js/dashboard.js

@@ -88 +88 @@
                 $('#publish').click( function() { act.val( 'post-quickpress-publish' ); } );
 
+                $('#title, #tags-input').each( function() {
+                        var input = $(this), prompt = $('#' + this.id + '-prompt-text');
+
+                        if ( '' === this.value )
+                                prompt.removeClass('screen-reader-text');
+
+                        prompt.click( function() {
+                                $(this).addClass('screen-reader-text');
+                                input.focus();
+                        });
+
+                        input.blur( function() {
+                                if ( '' === this.value )
+                                        prompt.removeClass('screen-reader-text');
+                        });
+
+                        input.focus( function() {
+                                prompt.addClass('screen-reader-text');
+                        });
+                });
         };
         quickPressLoad();