Changeset 21921

Timestamp:

09/19/2012 09:43:35 PM (12 years ago)

Author:

westi

Message:

Posting: Make it much harder to create posts with invalid dates by enforcing the post date tests in the UI and the backend code.

Previously you could quite easily send a new post into the back of beyond by specifying an invalid date like the 30th Feb and this was very confusing.
Sometimes it would seem to work and sometimes the post would end up very far in the past - depending on the mysql version and other factors.

Fixes #17180 props jkudish.

Location:

trunk

Files:

• wp-admin/includes/post.php (modified) (1 diff)
• wp-admin/js/post.js (modified) (1 diff)
• wp-includes/post.php (modified) (1 diff)

trunk/wp-admin/includes/post.php

@@ -123 +123 @@
         $mn = ($mn > 59 ) ? $mn -60 : $mn;
         $ss = ($ss > 59 ) ? $ss -60 : $ss;
+        $valid_date = apply_filters( '_wp_translate_postdata_valid_date', checkdate( $mm, $jj, $aa ), $post_data );
+        if ( !$valid_date ) {
+            return new WP_Error( 'invalid_date', __( 'Woops, the provided date is invalid.' ) );
+        }
         $post_data['post_date'] = sprintf( "%04d-%02d-%02d %02d:%02d:%02d", $aa, $mm, $jj, $hh, $mn, $ss );
         $post_data['post_date_gmt'] = get_gmt_from_date( $post_data['post_date'] );

trunk/wp-admin/js/post.js

@@ -527 +527 @@
             }
             return false;
+        });
+
+        $('#post').submit(function(e){
+            if ( !updateText() ) {
+                e.preventDefault();
+                $('#timestampdiv').show();
+                $('#publishing-action .ajax-loading').css('visibility', 'hidden');
+                $('#publish').prop('disabled', false).removeClass('button-primary-disabled');
+                return false;
+            }
         });
 

trunk/wp-includes/post.php

@@ -2634 +2634 @@
         $post_date = current_time('mysql');
 
+        // validate the date
+        $mm = substr( $post_date, 5, 2 );
+        $jj = substr( $post_date, 8, 2 );
+        $aa = substr( $post_date, 0, 4 );
+        $valid_date = apply_filters( 'wp_insert_post_validate_date', checkdate( $mm, $jj, $aa ), $post_date );
+        if ( !$valid_date ) {
+            return new WP_Error( 'invalid_date', __( 'Woops, the provided date is invalid.' ) );
+        }
+
     if ( empty($post_date_gmt) || '0000-00-00 00:00:00' == $post_date_gmt ) {
         if ( !in_array( $post_status, array( 'draft', 'pending', 'auto-draft' ) ) )