Changeset 21922 for trunk/wp-includes/post.php

Timestamp:

09/20/2012 10:46:50 AM (12 years ago)

Author:

westi

Message:

Posting: Improve the invalid date protection code based on feedback from nacin.

• Introduce a wp_checkdate() function with a single filter to centralise the code that validates dates.
• Improve the error message
• Correctly handle the return value of wp_insert_post which is not always a WP_Error on failure

Fixes #17180

File:

• trunk/wp-includes/post.php (modified) (1 diff)

trunk/wp-includes/post.php

@@ -2638 +2638 @@
         $jj = substr( $post_date, 8, 2 );
         $aa = substr( $post_date, 0, 4 );
-        $valid_date = apply_filters( 'wp_insert_post_validate_date', checkdate( $mm, $jj, $aa ), $post_date );
+        $valid_date = wp_checkdate( $mm, $jj, $aa, $post_date );
         if ( !$valid_date ) {
-            return new WP_Error( 'invalid_date', __( 'Woops, the provided date is invalid.' ) );
+            if ( $wp_error )
+                return new WP_Error( 'invalid_date', __( 'Whoops, the provided date is invalid.' ) );
+            else
+                return 0;
         }