Changeset 21943

Timestamp:

09/21/2012 06:52:15 PM (12 years ago)

Author:

nacin

Message:

Call clean_post_cache() in wp_insert_post() after the manual query to change GUID. Remove the second call to clean_post_cache() previously done on the save_post hook. see #11399.

Location:

trunk/wp-includes

Files:

• default-filters.php (modified) (1 diff)
• deprecated.php (modified) (1 diff)
• post.php (modified) (2 diffs)

trunk/wp-includes/default-filters.php

@@ -250 +250 @@
 add_action( 'pre_post_update',            'wp_save_post_revision'                          );
 add_action( 'publish_post',               '_publish_post_hook',                       5, 1 );
-add_action( 'save_post',                  '_save_post_hook',                          5, 2 );
 add_action( 'transition_post_status',     '_transition_post_status',                  5, 3 );
 add_action( 'transition_post_status',     '_update_term_count_on_transition_post_status', 10, 3 );

trunk/wp-includes/deprecated.php

@@ -3245 +3245 @@
     return true;
 }
+
+/**
+ * Callback formerly fired on the save_post hook. No longer needed.
+ *
+ * @since 2.3.0
+ * @deprecated 3.5.0
+ */
+function _save_post_hook() {}

trunk/wp-includes/post.php

@@ -2766 +2766 @@
     $current_guid = get_post_field( 'guid', $post_ID );
 
-    clean_post_cache( $post_ID );
-
     // Set GUID
     if ( !$update && '' == $current_guid )
         $wpdb->update( $wpdb->posts, array( 'guid' => get_permalink( $post_ID ) ), $where );
+
+    clean_post_cache( $post_ID );
 
     $post = get_post($post_ID);
@@ -4686 +4686 @@
 
 /**
- * Hook used to prevent page/post cache from staying dirty when a post is saved.
- *
- * @since 2.3.0
- * @access private
- *
- * @param int $post_id The ID in the database table for the $post
- * @param object $post Object type containing the post information
- */
-function _save_post_hook( $post_id, $post ) {
-    clean_post_cache( $post );
-}
-
-/**
  * Determines which fields of posts are to be saved in revisions.
  *