Changeset 21948 for trunk/wp-admin/edit-form-advanced.php

Timestamp:

09/21/2012 10:52:54 PM (12 years ago)

Author:

nacin

Message:

Use the regular post type UI for editing single media items (attachments).

• Attachments now go through post.php, edit_post(), the like, and have show_ui set to true.
• Taxonomies attached to the media library now appear in the admin menu (if show_ui).
• Editing, cropping, uploading, etc. is still very rough, but mostly functional.

API-wise:

• New function: get_taxonomies_for_attachments(). Like get_taxonomies(), for taxonomies specifically registered against attachments.
• Brings taxonomy support from the posts list table to the media list table. Expect them to converge soon.
• wp_insert_attachment() now handles taxonomies like wp_insert_post(). Also expect them to converge soon.
• New edit_form_after_title hook.

props helenyhou, ocean90. see #21391.

File:

• trunk/wp-admin/edit-form-advanced.php (modified) (9 diffs)

trunk/wp-admin/edit-form-advanced.php

@@ -64 +64 @@
     10 => sprintf( __('Page draft updated. <a target="_blank" href="%s">Preview page</a>'), esc_url( add_query_arg( 'preview', 'true', get_permalink($post_ID) ) ) ),
 );
+$messages['attachment'] = array_fill( 1, 10, __( 'Media attachment updated' ) ); // Hack, for now.
 
 $messages = apply_filters( 'post_updated_messages', $messages );
@@ -78 +79 @@
 $notice = false;
 $form_extra = '';
-if ( 'auto-draft' == $post->post_status ) {
+if ( 'auto-draft' == get_post_status( $post ) ) {
     if ( 'edit' == $action )
         $post->post_title = '';
@@ -107 +108 @@
 require_once('./includes/meta-boxes.php');
 
-add_meta_box('submitdiv', __('Publish'), 'post_submit_meta_box', null, 'side', 'core');
+if ( 'attachment' == $post_type ) {
+    wp_enqueue_script( 'image-edit' );
+    wp_enqueue_style( 'imgareaselect' );
+    add_meta_box( 'submitdiv', __('Save'), 'attachment_submit_meta_box', null, 'side', 'core' );
+    add_meta_box( 'attachmentdata', __('Attachment Page Content'), 'attachment_data_meta_box', null, 'normal', 'core' );
+    add_action( 'edit_form_after_title', 'edit_form_image_editor' );
+} else {
+    add_meta_box( 'submitdiv', __( 'Publish' ), 'post_submit_meta_box', null, 'side', 'core' );
+}
 
 if ( current_theme_supports( 'post-formats' ) && post_type_supports( $post_type, 'post-formats' ) )
@@ -113 +122 @@
 
 // all taxonomies
-foreach ( get_object_taxonomies($post_type) as $tax_name ) {
+foreach ( get_object_taxonomies( $post ) as $tax_name ) {
     $taxonomy = get_taxonomy($tax_name);
     if ( ! $taxonomy->show_ui )
@@ -145 +154 @@
     add_meta_box('commentstatusdiv', __('Discussion'), 'post_comment_status_meta_box', null, 'normal', 'core');
 
-if ( ('publish' == $post->post_status || 'private' == $post->post_status) && post_type_supports($post_type, 'comments') )
+if ( ( 'publish' == get_post_status( $post ) || 'private' == get_post_status( $post ) ) && post_type_supports($post_type, 'comments') )
     add_meta_box('commentsdiv', __('Comments'), 'post_comment_meta_box', null, 'normal', 'core');
 
-if ( !( 'pending' == $post->post_status && !current_user_can( $post_type_object->cap->publish_posts ) ) )
+if ( ! ( 'pending' == get_post_status( $post ) && ! current_user_can( $post_type_object->cap->publish_posts ) ) )
     add_meta_box('slugdiv', __('Slug'), 'post_slug_meta_box', null, 'normal', 'core');
 
@@ -270 +279 @@
 <?php
 }
-if ( 'draft' != $post->post_status )
+if ( 'draft' != get_post_status( $post ) )
     wp_original_referer_field(true, 'previous');
 
@@ -297 +306 @@
     $sample_permalink_html .= '<input id="shortlink" type="hidden" value="' . esc_attr($shortlink) . '" /><a href="#" class="button button-small" onclick="prompt(&#39;URL:&#39;, jQuery(\'#shortlink\').val()); return false;">' . __('Get Shortlink') . '</a>';
 
-if ( $post_type_object->public && ! ( 'pending' == $post->post_status && !current_user_can( $post_type_object->cap->publish_posts ) ) ) { ?>
+if ( $post_type_object->public && ! ( 'pending' == get_post_status( $post ) && !current_user_can( $post_type_object->cap->publish_posts ) ) ) { ?>
     <div id="edit-slug-box">
     <?php
-        if ( ! empty($post->ID) && ! empty($sample_permalink_html) && 'auto-draft' != $post->post_status )
+        if ( $sample_permalink_html && 'auto-draft' != get_post_status( $post ) )
             echo $sample_permalink_html;
     ?>
@@ -311 +320 @@
 wp_nonce_field( 'samplepermalink', 'samplepermalinknonce', false );
 ?>
-</div>
-<?php } ?>
-
-<?php if ( post_type_supports($post_type, 'editor') ) { ?>
+</div><!-- /titlediv -->
+<?php
+}
+
+do_action( 'edit_form_after_title' );
+
+if ( post_type_supports($post_type, 'editor') ) {
+?>
 <div id="postdivrich" class="postarea">
 
@@ -324 +337 @@
     <span class="autosave-message">&nbsp;</span>
 <?php
-    if ( 'auto-draft' != $post->post_status ) {
+    if ( 'auto-draft' != get_post_status( $post ) ) {
         echo '<span id="last-edit">';
         if ( $last_id = get_post_meta($post_ID, '_edit_last', true) ) {