Changeset 21948 for trunk/wp-includes/link-template.php

Timestamp:

09/21/2012 10:52:54 PM (12 years ago)

Author:

nacin

Message:

Use the regular post type UI for editing single media items (attachments).

• Attachments now go through post.php, edit_post(), the like, and have show_ui set to true.
• Taxonomies attached to the media library now appear in the admin menu (if show_ui).
• Editing, cropping, uploading, etc. is still very rough, but mostly functional.

API-wise:

• New function: get_taxonomies_for_attachments(). Like get_taxonomies(), for taxonomies specifically registered against attachments.
• Brings taxonomy support from the posts list table to the media list table. Expect them to converge soon.
• wp_insert_attachment() now handles taxonomies like wp_insert_post(). Also expect them to converge soon.
• New edit_form_after_title hook.

props helenyhou, ocean90. see #21391.

File:

• trunk/wp-includes/link-template.php (modified) (3 diffs)

trunk/wp-includes/link-template.php

@@ -107 +107 @@
         return get_page_link($post->ID, $leavename, $sample);
     elseif ( $post->post_type == 'attachment' )
-        return get_attachment_link($post->ID);
+        return get_attachment_link( $post->ID, $leavename );
     elseif ( in_array($post->post_type, get_post_types( array('_builtin' => false) ) ) )
         return get_post_permalink($post->ID, $leavename, $sample);
@@ -293 +293 @@
  *
  * @param mixed $post Optional. Post ID or object.
- * @return string
- */
-function get_attachment_link( $post = null ) {
+ * @param bool $leavename Optional. Leave name.
+ * @return string
+ */
+function get_attachment_link( $post = null, $leavename = false ) {
     global $wp_rewrite;
 
@@ -315 +316 @@
 
         if ( strpos($parentlink, '?') === false )
-            $link = user_trailingslashit( trailingslashit($parentlink) . $name );
+            $link = user_trailingslashit( trailingslashit($parentlink) . '%postname%' );
+
+        if ( ! $leavename )
+            $link = str_replace( '%postname%', $name, $link );
     }