Changeset 21948 for trunk/wp-includes/post.php

Timestamp:

09/21/2012 10:52:54 PM (13 years ago)

Author:

nacin

Message:

Use the regular post type UI for editing single media items (attachments).

• Attachments now go through post.php, edit_post(), the like, and have show_ui set to true.
• Taxonomies attached to the media library now appear in the admin menu (if show_ui).
• Editing, cropping, uploading, etc. is still very rough, but mostly functional.

API-wise:

• New function: get_taxonomies_for_attachments(). Like get_taxonomies(), for taxonomies specifically registered against attachments.
• Brings taxonomy support from the posts list table to the media list table. Expect them to converge soon.
• wp_insert_attachment() now handles taxonomies like wp_insert_post(). Also expect them to converge soon.
• New edit_form_after_title hook.

props helenyhou, ocean90. see #21391.

File:

• trunk/wp-includes/post.php (modified) (4 diffs)

trunk/wp-includes/post.php

@@ -53 +53 @@
     register_post_type( 'attachment', array(
         'labels' => array(
-            'name' => __( 'Media' ),
-            'edit_item' => __( 'Edit Media' ),
+            'name' => _x('Media', 'post type general name'),
+            'name_admin_bar' => _x( 'Media', 'add new from admin bar' ),
+            'add_new' => _x( 'Add New', 'add new media' ),
+            'edit_item' => __( 'Edit Media' ),
+            'view_item' => __( 'View Attachment Page' ),
         ),
         'public' => true,
-        'show_ui' => false,
+        'show_ui' => true,
         '_builtin' => true, /* internal use only. don't use this when registering your own post type. */
-        '_edit_link' => 'media.php?attachment_id=%d', /* internal use only. don't use this when registering your own post type. */
+        '_edit_link' => 'post.php?post=%d', /* internal use only. don't use this when registering your own post type. */
         'capability_type' => 'post',
         'map_meta_cap' => true,
@@ -67 +70 @@
         'show_in_nav_menus' => false,
         'delete_with_user' => true,
-        'supports' => array( 'comments', 'author' ),
+        'supports' => array( 'title', 'author', 'comments' ),
     ) );
 
@@ -3769 +3772 @@
         $post_status = 'inherit';
 
+    if ( !empty($post_category) )
+        $post_category = array_filter($post_category); // Filter out empty terms
+
     // Make sure we set a valid category.
-    if ( !isset($post_category) || 0 == count($post_category) || !is_array($post_category) ) {
-        // 'post' requires at least one category.
-        if ( 'post' == $post_type )
-            $post_category = array( get_option('default_category') );
-        else
-            $post_category = array();
+    if ( empty($post_category) || 0 == count($post_category) || !is_array($post_category) ) {
+        $post_category = array();
     }
 
@@ -3860 +3862 @@
     }
 
-    wp_set_post_categories($post_ID, $post_category);
+    if ( is_object_in_taxonomy($post_type, 'category') )
+        wp_set_post_categories( $post_ID, $post_category );
+
+    if ( isset( $tags_input ) && is_object_in_taxonomy($post_type, 'post_tag') )
+        wp_set_post_tags( $post_ID, $tags_input );
+
+    // support for all custom taxonomies
+    if ( !empty($tax_input) ) {
+        foreach ( $tax_input as $taxonomy => $tags ) {
+            $taxonomy_obj = get_taxonomy($taxonomy);
+            if ( is_array($tags) ) // array = hierarchical, string = non-hierarchical.
+                $tags = array_filter($tags);
+            if ( current_user_can($taxonomy_obj->cap->assign_terms) )
+                wp_set_post_terms( $post_ID, $tags, $taxonomy );
+        }
+    }
 
     if ( $file )