Changeset 21952

Timestamp:

09/22/2012 03:55:02 PM (12 years ago)

Author:

nacin

Message:

Stop cleaning the cache of a post's children. Ancestors are no longer cached against the post object, which means this kind of walking is unnecessary. It is also prohibitively expensive with large hierarchies.

We need to remove post_ancestors non-persistent caching for this. get_post_ancestors() can simply rely on the caching of get_post() instead. Previously, it was a direct query, hence the extra layers of caching and clearing.

Child cache clearing stays in wp_delete_post() as children get a new parent.

fixes #11399.

Location:

trunk/wp-includes

Files:

• load.php (modified) (1 diff)
• post.php (modified) (4 diffs)

trunk/wp-includes/load.php

@@ -411 +411 @@
     if ( function_exists( 'wp_cache_add_global_groups' ) ) {
         wp_cache_add_global_groups( array( 'users', 'userlogins', 'usermeta', 'user_meta', 'site-transient', 'site-options', 'site-lookup', 'blog-lookup', 'blog-details', 'rss', 'global-posts' ) );
-        wp_cache_add_non_persistent_groups( array( 'comment', 'counts', 'plugins', 'post_ancestors' ) );
+        wp_cache_add_non_persistent_groups( array( 'comment', 'counts', 'plugins' ) );
     }
 }

trunk/wp-includes/post.php

@@ -558 +558 @@
     $post = get_post( $post );
 
-    if ( ! $ancestors = wp_cache_get( $post->ID, 'post_ancestors' ) ) {
         $ancestors = array();
 
@@ -572 +571 @@
             }
         }
-
-        wp_cache_add( $post->ID, $ancestors, 'post_ancestors' );
-    }
 
     return $ancestors;
@@ -2219 +2215 @@
     clean_post_cache( $post );
 
-    if ( is_post_type_hierarchical( $post->post_type ) ) {
-        foreach ( (array) $children as $child )
+    if ( is_post_type_hierarchical( $post->post_type ) && $children ) {
+        foreach ( $children as $child )
             clean_post_cache( $child );
     }
@@ -4501 +4497 @@
         do_action( 'clean_page_cache', $post->ID );
     }
-
-    if ( $children = $wpdb->get_results( $wpdb->prepare("SELECT ID, post_type FROM $wpdb->posts WHERE post_parent = %d", $post->ID) ) ) {
-        foreach ( $children as $child ) {
-            // Loop detection
-            if ( $child->ID == $post->ID )
-                continue;
-            clean_post_cache( $child );
-        }
-    }
 }