Changeset 22044

Timestamp:

09/27/2012 06:20:22 AM (12 years ago)

Author:

koopersmith

Message:

Media JS: Move the modal box's title from being stored in the modal view to being stored as an attribute on the workflow. Update modal titles for both the post media and featured image workflows. see #21390, #21776.

Location:

trunk

Files:

• wp-admin/includes/meta-boxes.php (modified) (2 diffs)
• wp-admin/js/media-upload.js (modified) (1 diff)
• wp-includes/js/media-views.js (modified) (4 diffs)

trunk/wp-admin/includes/meta-boxes.php

@@ -1032 +1032 @@
             if ( ! workflow ) {
                 workflow = wp.media({
+                    title:   title,
                     library: {
                         type: 'image'
@@ -1059 +1060 @@
                     }).prependTo( $element );
                 });
-                workflow.modal.title( title );
             }
 

trunk/wp-admin/js/media-upload.js

@@ -104 +104 @@
 
             workflow = workflows[ id ] = wp.media( _.defaults( options || {}, {
+                title:    wp.media.view.l10n.insertMedia,
                 multiple: true
             } ) );

trunk/wp-includes/js/media-views.js

@@ -20 +20 @@
     media.controller.Workflow = Backbone.Model.extend({
         defaults: {
+            title:     '',
             multiple:  false,
             view:      'library',
@@ -194 +195 @@
         initialize: function() {
             this.controller = this.options.controller;
+            this.controller.on( 'change:title', this.render, this );
 
             _.defaults( this.options, {
-                title: '',
                 container: document.body
             });
@@ -209 +210 @@
             this.options.$content.detach();
 
-            this.$el.html( this.template( this.options ) );
+            this.$el.html( this.template( this.controller.toJSON() ) );
             this.$('.media-modal-content').append( this.options.$content );
             return this;
@@ -242 +243 @@
             // Set and render the content.
             this.options.$content = ( $content instanceof Backbone.View ) ? $content.$el : $content;
-            return this.render();
-        },
-
-        title: function( title ) {
-            this.options.title = title;
             return this.render();
         }