Changeset 22080 for trunk/wp-includes/comment.php

Timestamp:

09/28/2012 12:47:31 PM (14 years ago)

Author:

ryan

Message:

Invalidate the WP_Comment_Query:query() cache when comments are added. Switch last_changed to a counter incremented via wp_cache_incr().

fixes #22024

File:

• trunk/wp-includes/comment.php (modified) (3 diffs)

trunk/wp-includes/comment.php

@@ -250 +250 @@
                 // $args can be whatever, only use the args defined in defaults to compute the key
                 $key = md5( serialize( compact(array_keys($defaults)) )  );
-                $last_changed = wp_cache_get('last_changed', 'comment');
-                if ( ! $last_changed ) {
-                        $last_changed = time();
-                        wp_cache_set('last_changed', $last_changed, 'comment');
-                }
+                $last_changed = wp_cache_get( 'last_changed', 'comment' );
+                if ( ! $last_changed )
+                        $last_changed = wp_cache_set( 'last_changed', 1, 'comment' );
                 $cache_key = "get_comments:$key:$last_changed";
 
-                if ( $cache = wp_cache_get( $cache_key, 'comment' ) ) {
+                if ( $cache = wp_cache_get( $cache_key, 'comment' ) )
                         return $cache;
-                }
 
                 $post_id = absint($post_id);
@@ -1294 +1291 @@
         do_action('wp_insert_comment', $id, $comment);
 
+        wp_cache_incr( 'last_changed', 1, 'comment' );
+
         return $id;
 }
@@ -1965 +1964 @@
                 wp_cache_delete($id, 'comment');
 
-        wp_cache_set('last_changed', time(), 'comment');
+        wp_cache_incr( 'last_changed', 1, 'comment' );
 }