Changeset 22231 for trunk/wp-includes/meta.php

Timestamp:

10/15/2012 05:51:38 AM (13 years ago)

Author:

markjaquith

Message:

Defer the meta_id-fetching query until after comparison of the previous value, so that redundant calls to update_metadata() can bail without making that query. props nacin. fixes #22191

File:

• trunk/wp-includes/meta.php (modified) (2 diffs)

trunk/wp-includes/meta.php

@@ -124 +124 @@
         return (bool) $check;
 
-    if ( ! $meta_id = $wpdb->get_var( $wpdb->prepare( "SELECT $id_column FROM $table WHERE meta_key = %s AND $column = %d", $meta_key, $object_id ) ) )
-        return add_metadata($meta_type, $object_id, $meta_key, $passed_value);
-
     // Compare existing value to new value if no prev value given and the key exists only once.
     if ( empty($prev_value) ) {
@@ -135 +132 @@
         }
     }
+
+    if ( ! $meta_id = $wpdb->get_var( $wpdb->prepare( "SELECT $id_column FROM $table WHERE meta_key = %s AND $column = %d", $meta_key, $object_id ) ) )
+        return add_metadata($meta_type, $object_id, $meta_key, $passed_value);
 
     $_meta_value = $meta_value;