Changeset 22234

Timestamp:

10/15/2012 02:19:45 PM (12 years ago)

Author:

nacin

Message:

In nav menus, avoid firing the magic WP_Post getter for potentially non-existent properties, which results in a metadata cache hit. see #22189.

File:

• trunk/wp-admin/includes/nav-menu.php (modified) (2 diffs)

trunk/wp-admin/includes/nav-menu.php

@@ -248 +248 @@
         $output .= '<label class="menu-item-title">';
         $output .= '<input type="checkbox" class="menu-item-checkbox';
-        if ( ! empty( $item->_add_to_top ) ) {
+        if ( property_exists( $item, 'front_or_home' ) && $item->front_or_home ) {
+            $title = sprintf( _x( 'Home: %s', 'nav menu front page title' ), $item->post_title );
             $output .= ' add-to-top';
         }
         $output .= '" name="menu-item[' . $possible_object_id . '][menu-item-object-id]" value="'. esc_attr( $item->object_id ) .'" /> ';
-        $output .= empty( $item->label ) ? esc_html( $item->title ) : esc_html( $item->label );
+        $output .= isset( $title ) ? esc_html( $title ) : esc_html( $item->title );
         $output .= '</label>';
 
@@ -728 +729 @@
                     if ( ! empty( $front_page ) ) {
                         $front_page_obj = get_post( $front_page );
-                        $front_page_obj->_add_to_top = true;
-                        $front_page_obj->label = sprintf( _x('Home: %s', 'nav menu front page title'), $front_page_obj->post_title );
+                        $front_page_obj->front_or_home = true;
                         array_unshift( $posts, $front_page_obj );
                     } else {
                         $_nav_menu_placeholder = ( 0 > $_nav_menu_placeholder ) ? intval($_nav_menu_placeholder) - 1 : -1;
                         array_unshift( $posts, (object) array(
-                            '_add_to_top' => true,
+                            'front_or_home' => true,
                             'ID' => 0,
                             'object_id' => $_nav_menu_placeholder,