Changeset 22256

Timestamp:

10/17/2012 06:58:09 PM (14 years ago)

Author:

ryan

Message:

Don't create {$blog_id}_user-settings, {$blog_id}_user-settings-time, and {$blog_id}_dashboard_quick_press_last_post_id user options when a super admin visits a site they aren't a member of. Instead, rely solely on the wp-settings cookie.

fixes #22178

Location:

trunk

Files:

• wp-admin/includes/dashboard.php (modified) (1 diff)
• wp-includes/option.php (modified) (2 diffs)

trunk/wp-admin/includes/dashboard.php

@@ -491 +491 @@
                 if ( empty( $post ) || $post->post_status != 'auto-draft' ) { // auto-draft doesn't exists anymore
                         $post = get_default_post_to_edit('post', true);
-                        update_user_option( (int) $GLOBALS['current_user']->ID, 'dashboard_quick_press_last_post_id', (int) $post->ID ); // Save post_ID
+                        update_user_option( get_current_user_id(), 'dashboard_quick_press_last_post_id', (int) $post->ID ); // Save post_ID
                 } else {
                         $post->post_title = ''; // Remove the auto draft title
                 }
         } else {
-                $post = get_default_post_to_edit('post', true);
-                update_user_option( (int) $GLOBALS['current_user']->ID, 'dashboard_quick_press_last_post_id', (int) $post->ID ); // Save post_ID
+                $post = get_default_post_to_edit( 'post' , true);
+                $user_id = get_current_user_id();
+                // Don't create an option if this is a super admin who does not belong to this site.
+                if ( ! ( is_super_admin( $user_id ) && ! in_array( get_current_blog_id(), array_keys( get_blogs_of_user( $user_id ) ) ) ) )
+                        update_user_option( $user_id, 'dashboard_quick_press_last_post_id', (int) $post->ID ); // Save post_ID
         }
 

trunk/wp-includes/option.php

@@ -541 +541 @@
                 return;
 
+        if ( is_super_admin( $user->ID ) &&
+                ! in_array( get_current_blog_id(), array_keys( get_blogs_of_user( $user->ID ) ) )
+                )
+                return;
+
         $settings = get_user_option( 'user-settings', $user->ID );
 
@@ -697 +702 @@
         if ( ! $user = wp_get_current_user() )
                 return false;
+
+        if ( is_super_admin( $user->ID ) &&
+                ! in_array( get_current_blog_id(), array_keys( get_blogs_of_user( $user->ID ) ) )
+                )
+                return;
 
         $_updated_user_settings = $all;