Changeset 22339

Timestamp:

10/30/2012 11:59:57 PM (14 years ago)

Author:

koopersmith

Message:

Media JS: Several improvements to the Attachment views.

• Bind Attachment details updates to the Attachments initialize method.
• Improve Attachment view unbinding.
• Re-render Attachment views when titles and captions are updated.

see #21390.

File:

• trunk/wp-includes/js/media-views.js (modified) (3 diffs)

trunk/wp-includes/js/media-views.js

@@ -1040 +1040 @@
                         this.controller = this.options.controller;
 
-                        this.model.on( 'change:sizes change:uploading', this.render, this );
+                        this.model.on( 'change:sizes change:uploading change:caption change:title', this.render, this );
                         this.model.on( 'change:percent', this.progress, this );
                         this.model.on( 'add', this.select, this );
                         this.model.on( 'remove', this.deselect, this );
 
+                        // Update the model's details view.
+                        this.model.on( 'selection:single selection:unsingle', this.details, this );
+                        this.details( this.model, this.controller.state().get('selection') );
+
                         // Prevent default navigation on all links.
                         this.$el.on( 'click', 'a', this.preventDefault );
                 },
 
+                destroy: function() {
+                        this.model.off( null, null, this );
+                },
+
                 render: function() {
-                        var state = this.controller.state(),
-                                attachment = this.model.toJSON(),
+                        var attachment = this.model.toJSON(),
                                 options = _.defaults( this.model.toJSON(), {
                                         orientation: 'landscape',
@@ -1064 +1071 @@
 
                         options.buttons  = this.buttons;
-                        options.describe = state.get('describe');
+                        options.describe = this.controller.state().get('describe');
 
                         if ( 'image' === options.type )
@@ -1080 +1087 @@
                                 this.select();
 
-                        // Update the model's details view.
-                        this.model.on( 'selection:single selection:unsingle', this.details, this );
-                        this.details( this.model, state.get('selection') );
-
-                        return this;
-                },
-
-                destroy: function() {
-                        this.model.off( 'single', this.details, this );
+                        return this;
                 },