Changeset 22399

Timestamp:

11/06/2012 02:46:56 PM (13 years ago)

Author:

duck_

Message:

Correctly associate new menu items with a menu when using wp_update_nav_menu_item()

wp_update_nav_menu_item() must pass tax_input to wp_insert_post() when creating items
otherwise the menu-item relationship isn't made.

See #22189.

File:

• trunk/wp-includes/nav-menu.php (modified) (1 diff)

trunk/wp-includes/nav-menu.php

@@ -348 +348 @@
     );
 
-    if ( $menu_id && ! is_object_in_term( $menu_item_db_id, 'nav_menu', (int) $menu->term_id ) )
+    $update = 0 != $menu_item_db_id;
+
+    // Only set the menu term if it isn't set to avoid unnecessary wp_get_object_terms()
+    if ( $menu_id && ( ! $update || ! is_object_in_term( $menu_item_db_id, 'nav_menu', (int) $menu->term_id ) ) )
         $post['tax_input'] = array( 'nav_menu' => array( intval( $menu->term_id ) ) );
-
-    $update = 0 != $menu_item_db_id;
 
     // New menu item. Default is draft status